207492 – [ews] Use SetBuildSummary instead of buildFinished in Layout tests

Bug 207492 - [ews] Use SetBuildSummary instead of buildFinished in Layout tests

Summary: [ews] Use SetBuildSummary instead of buildFinished in Layout tests

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	Tools / Tests (show other bugs)
Version:	Other
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Aakash Jain

URL:
Keywords:	InRadar

Depends on:
Blocks:	201934
	Show dependency tree / graph

Reported:	2020-02-10 12:12 PST by Aakash Jain
Modified:	2020-02-19 07:41 PST (History)
CC List:	4 users (show)

See Also:

Attachments
Patch (2.99 KB, patch) 2020-02-10 12:14 PST, Aakash Jain	jbedard: review+	Details \| Formatted Diff \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Aakash Jain 2020-02-10 12:12:25 PST

[ews] Use SetBuildSummary instead of buildFinished in Layout tests to set custom build summary. buildFinished() method finishes the build immediately, while it might not be desirable in some cases/factories. 

We added SetBuildSummary build step in https://bugs.webkit.org/show_bug.cgi?id=207026 for this purpose. We are using that for webkitpy tests. We should start using that that in layout-tests as well.

Comment 1 Aakash Jain 2020-02-10 12:14:14 PST

Created attachment 390282 [details]
Patch

Comment 2 Aakash Jain 2020-02-10 12:17:08 PST

Sample runs:

No failures: https://ews-build.webkit-uat.org/#/builders/16/builds/76
Flaky failures: https://ews-build.webkit-uat.org/#/builders/16/builds/80
pre-existing test failures: https://ews-build.webkit-uat.org/#/builders/16/builds/82

Comment 3 Aakash Jain 2020-02-10 13:14:42 PST

Committed r256206: <https://trac.webkit.org/changeset/256206>

Comment 4 Radar WebKit Bug Importer 2020-02-10 13:15:16 PST

<rdar://problem/59322779>