RESOLVED FIXED 207492
[ews] Use SetBuildSummary instead of buildFinished in Layout tests 
https://bugs.webkit.org/show_bug.cgi?id=207492
Summary [ews] Use SetBuildSummary instead of buildFinished in Layout tests
Aakash Jain
Reported 2020-02-10 12:12:25 PST
[ews] Use SetBuildSummary instead of buildFinished in Layout tests to set custom build summary. buildFinished() method finishes the build immediately, while it might not be desirable in some cases/factories. We added SetBuildSummary build step in https://bugs.webkit.org/show_bug.cgi?id=207026 for this purpose. We are using that for webkitpy tests. We should start using that that in layout-tests as well.
Attachments
Patch (2.99 KB, patch)
2020-02-10 12:14 PST, Aakash Jain 		jbedard: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2020-02-10 12:14:14 PST
Created attachment 390282 [details] Patch
Aakash Jain
Comment 3 2020-02-10 13:14:42 PST
Committed r256206: <https://trac.webkit.org/changeset/256206>
Radar WebKit Bug Importer
Comment 4 2020-02-10 13:15:16 PST
<rdar://problem/59322779>
Note You need to log in before you can comment on or make changes to this bug.