Bug 207556 - [ews] add SetBuildSummary step for Windows EWS
Summary: [ews] add SetBuildSummary step for Windows EWS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-11 09:10 PST by Aakash Jain
Modified: 2020-02-17 08:50 PST (History)
2 users (show)

See Also:

Attachments
Patch (3.16 KB, patch)
2020-02-11 09:16 PST, Aakash Jain 		no flags Details | Formatted Diff | Diff
Patch (3.16 KB, patch)
2020-02-11 09:22 PST, Aakash Jain 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2020-02-11 09:10:26 PST 
add SetBuildSummary step for Windows EWS. Follow-up to Bug 207492.
Comment 1 Aakash Jain 2020-02-11 09:16:16 PST 
Created attachment 390373 [details]
Patch
Comment 2 Aakash Jain 2020-02-11 09:22:06 PST 
Created attachment 390374 [details]
Patch
Comment 3 Jonathan Bedard 2020-02-11 14:29:33 PST 
Comment on attachment 390374 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390374&action=review

> Tools/ChangeLog:10
> +        (GTKBuildAndTestFactory.__init__):

Adding it for GTK too?
Comment 4 Aakash Jain 2020-02-11 14:33:02 PST 
This change would fix the build summary for builds like this: https://ews-build.webkit.org/#/builders/10/builds/7056
Comment 5 Aakash Jain 2020-02-11 14:33:25 PST 
(In reply to Jonathan Bedard from comment #3)
> Adding it for GTK too?
Yes, because GTK factory also have the same layout-test step which was modified in Bug 207492. Although that code path is not used currently by any GTK factory.
Comment 6 Aakash Jain 2020-02-17 08:49:05 PST 
Committed r256729: <https://trac.webkit.org/changeset/256729>
Comment 7 Radar WebKit Bug Importer 2020-02-17 08:50:18 PST 
<rdar://problem/59512176>