Summary: | Use ObjectIdentifier for WebSocketStream/WebSocketChannel | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||
Component: | Service Workers | Assignee: | youenn fablet <youennf> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | achristensen, commit-queue, webkit-bug-importer, ysuzuki | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
youenn fablet
2020-02-10 14:02:01 PST
Created attachment 390293 [details]
Patch
Comment on attachment 390293 [details] Patch Clearing flags on attachment: 390293 Committed r256303: <https://trac.webkit.org/changeset/256303> All reviewed patches have been landed. Closing bug. Comment on attachment 390293 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390293&action=review > Source/WebKit/WebProcess/Network/WebSocketChannelManager.h:51 > + HashMap<WebSocketIdentifier, Ref<WebSocketChannel>> m_channels; BTW, which one is responsible to removing entry from this table? Thanks Yusuke, filed https://bugs.webkit.org/show_bug.cgi?id=210424 (In reply to youenn fablet from comment #6) > Thanks Yusuke, filed https://bugs.webkit.org/show_bug.cgi?id=210424 Cool! Thanks :D |