Bug 207507

Summary: Use ObjectIdentifier for WebSocketStream/WebSocketChannel
Product: WebKit Reporter: youenn fablet <youennf>
Component: Service WorkersAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

youenn fablet
Reported 2020-02-10 14:02:01 PST
Use ObjectIdentifier for WebSocketStream/WebSocketChannel
Attachments
Patch (31.59 KB, patch)
2020-02-10 14:06 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2020-02-10 14:06:22 PST
Created attachment 390293 [details] Patch
WebKit Commit Bot
Comment 2 2020-02-11 06:08:35 PST
Comment on attachment 390293 [details] Patch Clearing flags on attachment: 390293 Committed r256303: <https://trac.webkit.org/changeset/256303>
WebKit Commit Bot
Comment 3 2020-02-11 06:08:37 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2020-02-11 06:09:16 PST
<rdar://problem/59346060>
Yusuke Suzuki
Comment 5 2020-04-13 05:20:16 PDT
Comment on attachment 390293 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390293&action=review > Source/WebKit/WebProcess/Network/WebSocketChannelManager.h:51 > + HashMap<WebSocketIdentifier, Ref<WebSocketChannel>> m_channels; BTW, which one is responsible to removing entry from this table?
youenn fablet
Comment 6 2020-04-13 07:46:33 PDT
Thanks Yusuke, filed https://bugs.webkit.org/show_bug.cgi?id=210424
Yusuke Suzuki
Comment 7 2020-04-13 08:35:14 PDT
(In reply to youenn fablet from comment #6) > Thanks Yusuke, filed https://bugs.webkit.org/show_bug.cgi?id=210424 Cool! Thanks :D
Note You need to log in before you can comment on or make changes to this bug.