Bug 207379

Summary: [WPE] Use custom theme style to render text fields
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WPE WebKitAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, aperez, bugs-noreply, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, macpherson, menard, ryuan.choi, sergio
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=207328
Bug Depends on:    
Bug Blocks: 207471    
Attachments:
Description Flags
Patch aperez: review+

Carlos Garcia Campos
Reported 2020-02-07 02:20:41 PST
This includes text entries, text areas and search fields.
Attachments
Patch (10.61 KB, patch)
2020-02-07 02:25 PST, Carlos Garcia Campos 		aperez: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2020-02-07 02:25:40 PST
Created attachment 390069 [details] Patch
Adrian Perez
Comment 2 2020-02-14 06:18:09 PST
Comment on attachment 390069 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390069&action=review Patch LGTM with a small unimportant nit :] > Source/WebCore/platform/wpe/RenderThemeWPE.cpp:43 > +static const int textFieldBorderSize = 1; Nit: I would use “unsigned” here, as it does not make sense to allow negative values for a border.
Carlos Garcia Campos
Comment 3 2020-02-14 06:27:29 PST
Comment on attachment 390069 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390069&action=review >> Source/WebCore/platform/wpe/RenderThemeWPE.cpp:43 >> +static const int textFieldBorderSize = 1; > > Nit: I would use “unsigned” here, as it does not make sense to allow > negative values for a border. It's used with negative value for .inflate(), that's why I changed it to int. > Source/WebCore/platform/wpe/RenderThemeWPE.cpp:128 > + fieldRect.inflate(-borderSize); Here.
Carlos Garcia Campos
Comment 4 2020-02-17 01:08:00 PST
Committed r256724: <https://trac.webkit.org/changeset/256724>
Note You need to log in before you can comment on or make changes to this bug.