Summary: | mingw32 cross-compile from linux: VK_BACK and friends already #defined | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Luke Kenneth Casson Leighton <lkcl> | ||||
Component: | WebKit Misc. | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED DUPLICATE | ||||||
Severity: | Normal | CC: | camaradetux, laszlo.gombos, ossy | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 37916, 43191 | ||||||
Attachments: |
|
Description
Luke Kenneth Casson Leighton
2008-09-08 05:56:21 PDT
Created attachment 23251 [details]
#ifndef around all VC_XXX consts
After some hacking this week-end I found out WX had the same problem. See WebCore/config.h : // The defines in KeyboardCodes.h conflict with Windows as well, and the only way I've found // to address the problem is include KeyboarddCodes.h before windows.h, so do it here. I think other builds could suffer from that too. Moreover there don't seem to be any drawback to adding those checks. Now that webkit-gtk is quite easy to get working on win32, this patch would be more than welcome. It still applies cleanly to trunk. This worked for me. --- ../WebKit-r39903/WebCore/platform/gtk/KeyEventGtk.cpp 2008-12-24 23:47:40.000000000 -0500 +++ WebCore/platform/gtk/KeyEventGtk.cpp 2009-02-09 09:33:28.000000000 -0500 @@ -27,10 +27,10 @@ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ +#include "KeyboardCodes.h" #include "config.h" #include "PlatformKeyboardEvent.h" -#include "KeyboardCodes.h" #include "NotImplemented.h" #include "TextEncoding.h" *** Bug 43360 has been marked as a duplicate of this bug. *** |