Bug 207014

Summary:

[Web Animations] DocumentTimeline shouldn't suspend itself if hiddenPageCSSAnimationSuspensionEnabled is disabled

Product:

WebKit

Reporter:

Antoine Quint <graouts>

Component:

New Bugs

Assignee:

Antoine Quint <graouts>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dino, jonlee, koivisto, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=207042

Attachments:

Description	Flags
Patch	none
Patch	koivisto: review+

Description Antoine Quint 2020-01-30 12:29:23 PST

[Web Animations] DocumentTimeline shouldn't suspend itself

Comment 1 Antoine Quint 2020-01-30 12:31:33 PST

Created attachment 389276 [details]
Patch

Comment 2 Antoine Quint 2020-01-30 12:31:38 PST

<rdar://problem/58815952>

Comment 3 Jon Lee 2020-01-30 14:18:12 PST

Comment on attachment 389276 [details]
Patch

it didn't work

Comment 4 Antoine Quint 2020-01-31 00:50:47 PST

Created attachment 389335 [details]
Patch

Comment 5 Antoine Quint 2020-01-31 02:20:23 PST

Committed r255489: <https://trac.webkit.org/changeset/255489>

Comment 6 Antti Koivisto 2020-01-31 02:27:55 PST

Comment on attachment 389335 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389335&action=review

> Source/WebCore/animation/DocumentTimeline.cpp:70
> +            if (page->settings().hiddenPageCSSAnimationSuspensionEnabled() && !page->isVisible())

Wonder why we need hiddenPageCSSAnimationSuspensionEnabled flag at all? What is the case where we wouldn't want to suspend non-visible pages?