Bug 206712

Summary: Add a variant of -selectPositionAtPoint that can select an arbitrary point
Product: WebKit Reporter: Daniel Bates <dbates>
Component: WebKit Misc.Assignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
To Land
none
To land after bug #207366 none

Description Daniel Bates 2020-01-23 16:01:13 PST 
Add a variant of -selectPositionAtPoint that takes a boolean as to whether to constrain the point to stay within the focused element. This will be used in a future patch to select an arbitrary point on the page regardless of whether doing so changes focus.
Comment 1 Daniel Bates 2020-01-23 16:05:56 PST 
Created attachment 388607 [details]
Patch
Comment 2 Daniel Bates 2020-01-23 16:08:01 PST 
Comment on attachment 388607 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388607&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.h:450
> +- (void)_selectPositionAtPoint:(CGPoint)point stayingWithinFocusedElement:(BOOL)isInteractingWithFocusedElement completionHandler:(void (^)(void))completionHandler;

isInteractingWithFocusedElement => stayingWithinFocusedElement
Comment 3 Daniel Bates 2020-01-23 16:09:40 PST 
Created attachment 388609 [details]
To Land
Comment 4 Daniel Bates 2020-01-23 16:11:00 PST 
Comment on attachment 388609 [details]
To Land

Clearing flags on attachment: 388609

Committed r255042: <https://trac.webkit.org/changeset/255042>
Comment 5 Daniel Bates 2020-01-23 16:11:01 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2020-01-23 16:11:11 PST 
<rdar://problem/58852706>
Comment 7 Daniel Bates 2020-02-07 09:43:22 PST Comment hidden (obsolete)
Comment 8 Daniel Bates 2020-02-07 09:43:22 PST Comment hidden (obsolete)