Bug 206712

Summary:

Add a variant of -selectPositionAtPoint that can select an arbitrary point

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

WebKit Misc.

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
To Land	none
To land after bug #207366	none

Daniel Bates

Reported 2020-01-23 16:01:13 PST

Add a variant of -selectPositionAtPoint that takes a boolean as to whether to constrain the point to stay within the focused element. This will be used in a future patch to select an arbitrary point on the page regardless of whether doing so changes focus.

Attachments
Patch (3.57 KB, patch) 2020-01-23 16:05 PST, Daniel Bates	no flags	Details Formatted Diff Diff
To Land (3.56 KB, patch) 2020-01-23 16:09 PST, Daniel Bates	no flags	Details Formatted Diff Diff
To land after bug #207366 (71.86 KB, patch) 2020-02-07 09:43 PST, Daniel Bates	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Daniel Bates

Comment 1 2020-01-23 16:05:56 PST

Created attachment 388607 [details] Patch

Daniel Bates

Comment 2 2020-01-23 16:08:01 PST

Comment on attachment 388607 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388607&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.h:450 > +- (void)_selectPositionAtPoint:(CGPoint)point stayingWithinFocusedElement:(BOOL)isInteractingWithFocusedElement completionHandler:(void (^)(void))completionHandler; isInteractingWithFocusedElement => stayingWithinFocusedElement

Daniel Bates

Comment 3 2020-01-23 16:09:40 PST

Created attachment 388609 [details] To Land

Daniel Bates

Comment 4 2020-01-23 16:11:00 PST

Comment on attachment 388609 [details] To Land Clearing flags on attachment: 388609 Committed r255042: <https://trac.webkit.org/changeset/255042>

Daniel Bates

Comment 5 2020-01-23 16:11:01 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 6 2020-01-23 16:11:11 PST

<rdar://problem/58852706>

Daniel Bates

Comment 7 2020-02-07 09:43:22 PST Comment hidden (obsolete)

Reopening to attach new patch.

Daniel Bates

Comment 8 2020-02-07 09:43:22 PST Comment hidden (obsolete)

Created attachment 390091 [details] To land after bug #207366 Patch now formally depends on bug #207366. This simplifies the patch as I no longer need to add Mac- and iOS-specific results.

Note You need to log in before you can comment on or make changes to this bug.