Summary: | Don't include BytecodeStructs.h in CommonSlowPaths.h | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Robin Morisset <rmorisset> | ||||||||
Component: | JavaScriptCore | Assignee: | Robin Morisset <rmorisset> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=206563 | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 206720 | ||||||||||
Attachments: |
|
Description
Robin Morisset
2020-01-21 19:18:27 PST
Created attachment 388390 [details]
WIP
I only have to actually measure the compile times for the Changelog, this patch is otherwise ready.
Created attachment 388570 [details]
Patch
The compile time improvement is sadly too small to measure in the noise, but I still think it is worth landing as it is a fairly trivial patch.
I've also fixed the patch, as the new file was added in the wrong directory, and two forward declarations are no longer needed.
Created attachment 388591 [details]
Patch
Fixing style nits.
Comment on attachment 388591 [details]
Patch
r=me
Comment on attachment 388591 [details] Patch Clearing flags on attachment: 388591 Committed r255040: <https://trac.webkit.org/changeset/255040> All reviewed patches have been landed. Closing bug. |