Bug 206566

Summary: Don't include BytecodeStructs.h in CommonSlowPaths.h
Product: WebKit Reporter: Robin Morisset <rmorisset>
Component: JavaScriptCoreAssignee: Robin Morisset <rmorisset>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=206563
Bug Depends on:    
Bug Blocks: 206720    
Attachments:
Description Flags
WIP
none
Patch
none
Patch none

Robin Morisset
Reported 2020-01-21 19:18:27 PST
BytecodeStructs.h is quite large, even after https://bugs.webkit.org/show_bug.cgi?id=206563 (roughly 40k lines). It is currently inlined in CommonSlowPaths.h just for 2 functions, which are only used in 2 cpp files. Not only is CommonSlowPaths.h directly included in many places, but it it is also included in JIT.h, which is included by something like half of JSC. By only including BytecodeStructs.h in a more specialized CommonSlowPathsInlines.h I hope to improve compile times.
Attachments
WIP (26.60 KB, patch)
2020-01-21 19:21 PST, Robin Morisset 		no flags
DetailsFormatted DiffDiff
Patch (25.69 KB, patch)
2020-01-23 11:44 PST, Robin Morisset 		no flags
DetailsFormatted DiffDiff
Patch (25.73 KB, patch)
2020-01-23 14:25 PST, Robin Morisset 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Robin Morisset
Comment 1 2020-01-21 19:21:18 PST
Created attachment 388390 [details] WIP I only have to actually measure the compile times for the Changelog, this patch is otherwise ready.
Robin Morisset
Comment 2 2020-01-23 11:44:51 PST
Created attachment 388570 [details] Patch The compile time improvement is sadly too small to measure in the noise, but I still think it is worth landing as it is a fairly trivial patch. I've also fixed the patch, as the new file was added in the wrong directory, and two forward declarations are no longer needed.
Robin Morisset
Comment 3 2020-01-23 14:25:48 PST
Created attachment 388591 [details] Patch Fixing style nits.
Tadeu Zagallo
Comment 4 2020-01-23 14:40:58 PST
Comment on attachment 388591 [details] Patch r=me
WebKit Commit Bot
Comment 5 2020-01-23 15:25:37 PST
Comment on attachment 388591 [details] Patch Clearing flags on attachment: 388591 Committed r255040: <https://trac.webkit.org/changeset/255040>
WebKit Commit Bot
Comment 6 2020-01-23 15:25:39 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2020-01-23 15:26:18 PST
<rdar://problem/58851022>
Note You need to log in before you can comment on or make changes to this bug.