Summary: | [LFC] Cache display box for the first LayoutState to Layout::Box | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||
Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bfulgham, commit-queue, simon.fraser, webkit-bug-importer, zalan | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Antti Koivisto
2020-01-15 07:11:54 PST
Created attachment 387791 [details]
patch
This pattern needs to be revisited when we start adding support for multiple LayoutStates such as printing, snapshots etc. (In reply to zalan from comment #2) > This pattern needs to be revisited when we start adding support for multiple > LayoutStates such as printing, snapshots etc. The pattern does work with multiple LayoutStates. It just only helps when there is 1. (In reply to Antti Koivisto from comment #3) > (In reply to zalan from comment #2) > > This pattern needs to be revisited when we start adding support for multiple > > LayoutStates such as printing, snapshots etc. > > The pattern does work with multiple LayoutStates. It just only helps when > there is 1. I guess I should have read it more carefully. The commit-queue encountered the following flaky tests while processing attachment 387791 [details]: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch. The commit-queue encountered the following flaky tests while processing attachment 387791 [details]: media/track/track-in-band-metadata-display-order.html bug 206226 (author: jer.noble@apple.com) The commit-queue is continuing to process your patch. The commit-queue encountered the following flaky tests while processing attachment 387791 [details]:
The commit-queue is continuing to process your patch.
The commit-queue encountered the following flaky tests while processing attachment 387791 [details]: media/track/track-cues-sorted-before-dispatch.html bug 206225 (authors: simon.pena@samsung.com and vcarbune@chromium.org) The commit-queue is continuing to process your patch. The commit-queue encountered the following flaky tests while processing attachment 387791 [details]: editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org) The commit-queue is continuing to process your patch. Comment on attachment 387791 [details] patch Clearing flags on attachment: 387791 Committed r254634: <https://trac.webkit.org/changeset/254634> All reviewed patches have been landed. Closing bug. |