| Summary: | Clean-up MediaPlayerPrivateMediaStreamAVFObjC.h/.mm | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||
| Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer, youennf | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 206066 | ||||||||
| Attachments: |
|
||||||||
|
Description
youenn fablet
2020-01-10 04:05:12 PST
Created attachment 387328 [details]
Patch
Comment on attachment 387328 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=387328&action=review > Source/WebCore/ChangeLog:3 > + Clean-up MediaPlayerPrivateMediaStreamAVFObjC.h Nit: should probably update the bug name as you change both files. Created attachment 387504 [details]
Patch for landing
Comment on attachment 387504 [details] Patch for landing Rejecting attachment 387504 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 387504, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=387504&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=206060&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Updating working directory Processing patch 387504 from bug 206060. Fetching: https://bugs.webkit.org/attachment.cgi?id=387504 Authentication required Authentication required Authentication required Updating OpenSource From https://git.webkit.org/git/WebKit 17265b441d3..7eacf652640 master -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 254432 = 17265b441d342970b25dd93a8c7dc69af9f0b850 r254433 = c3d5144b66238a19c3916664b516c548b90bd94a r254434 = 7eacf65264049f66dea65e31ab84c9e12ef9b8d1 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: https://webkit-queues.webkit.org/results/13303512 Comment on attachment 387504 [details] Patch for landing Clearing flags on attachment: 387504 Committed r254465: <https://trac.webkit.org/changeset/254465> All reviewed patches have been landed. Closing bug. |