Bug 205991

Summary:

Bad baseline for Catalina on xhr web-platform-tests imported in r254154

Product:

WebKit

Reporter:

Pablo Saavedra <psaavedra>

Component:

Tools / Tests

Assignee:

Pablo Saavedra <psaavedra>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, clopez, commit-queue, tsavell, webkit-bot-watchers-bugzilla, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	none
patch	none

Pablo Saavedra

Reported 2020-01-08 23:32:00 PST

Related to: https://bugs.webkit.org/show_bug.cgi?id=205641 (Re-sync web-platform-tests/xhr from upstream) Requires a baseline rebasing

Attachments
patch (4.63 KB, patch) 2020-01-08 23:34 PST, Pablo Saavedra	no flags	Details Formatted Diff Diff
patch (4.68 KB, patch) 2020-01-09 11:13 PST, Pablo Saavedra	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Pablo Saavedra

Comment 1 2020-01-08 23:34:29 PST

Created attachment 387196 [details] patch

Pablo Saavedra

Comment 2 2020-01-09 02:58:01 PST

Testing the new patch in my local macpro with catalina: ``` macpro:WebKit psaavedra$ system_profiler SPSoftwareDataType | grep Version System Version: macOS 10.15.2 (19C57) Kernel Version: Darwin 19.2.0 macpro:WebKit psaavedra$ cat ooo.out python ./Tools/Scripts/run-webkit-tests --no-build --no-show-results --no-new-test-results --clobber-old-results --exit-after-n-crashes-or-timeouts 50 --exit-after-n-failures 500 --release --results-directory layout-test-results --no-retry-failures LayoutTests/imported/w3c/web-platform-tests/xhr/getallresponseheaders.htm Using port 'mac-catalina-wk2' Test configuration: <catalina, x86_64, release> Placing test results in /Volumes/external/psaavedra/WebKit/layout-test-results Using Release build Pixel tests disabled Regular timeout: 30000, slow test timeout: 150000 Command line: /Volumes/external/psaavedra/WebKit/WebKitBuild/Release/WebKitTestRunner - Collecting tests ... Parsing expectations ... Found 1 test; running 1, skipping 0. Checking build ... Clobbering old results in /Volumes/external/psaavedra/WebKit/layout-test-results Verbose baseline search path: platform/mac-catalina-wk2 -> platform/mac-catalina -> platform/mac-wk2 -> platform/mac -> platform/wk2 -> generic Baseline search path: platform/mac-wk2 -> platform/mac -> platform/wk2 -> generic Running 1 test Starting helper ... Checking system dependencies ... Sharding tests ... Running 1 WebKitTestRunner. Starting 1 worker ... The test ran as expected. ```

Pablo Saavedra

Comment 3 2020-01-09 08:24:44 PST

Failed tests in ios-wk2 are not related with xhr.

Pablo Saavedra

Comment 4 2020-01-09 11:13:47 PST

Created attachment 387246 [details] patch

Pablo Saavedra

Comment 5 2020-01-09 11:20:26 PST

The queues in EWS are being slower than usual. Because I've tested the changes in Catalina (in local), I've decided to send the patch to the commit queue at last.

WebKit Commit Bot

Comment 6 2020-01-09 11:52:20 PST

Comment on attachment 387246 [details] patch Clearing flags on attachment: 387246 Committed r254285: <https://trac.webkit.org/changeset/254285>

WebKit Commit Bot

Comment 7 2020-01-09 11:52:22 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 8 2020-01-09 11:53:15 PST

<rdar://problem/58451641>

Note You need to log in before you can comment on or make changes to this bug.