Bug 205965

Summary: [PlayStation] Enable WebKit
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: WebKit2Assignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, basuke, bfulgham, commit-queue, ews-watchlist, gyuyoung.kim, ross.kirsling, ryuan.choi, sergio, webkit-bug-importer
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 205964, 206186, 206198, 206243, 206247, 206267, 206320, 206323, 206324    
Bug Blocks:    
Attachments:
Description Flags
WIP Patch
none
WIP Patch
none
WIP Patch
none
Patch
ross.kirsling: review+
Patch none

Don Olmstead
Reported 2020-01-08 15:49:03 PST
Enable WebKit for the PlayStation port
Attachments
WIP Patch (33.17 KB, patch)
2020-01-14 13:43 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
WIP Patch (33.14 KB, patch)
2020-01-14 13:44 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
WIP Patch (31.36 KB, patch)
2020-01-14 13:56 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (39.89 KB, patch)
2020-01-16 14:02 PST, Don Olmstead 		ross.kirsling: review+
DetailsFormatted DiffDiff
Patch (38.44 KB, patch)
2020-01-16 14:47 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2020-01-14 13:43:03 PST Comment hidden (obsolete)
Don Olmstead
Comment 2 2020-01-14 13:44:20 PST Comment hidden (obsolete)
Don Olmstead
Comment 3 2020-01-14 13:56:09 PST Comment hidden (obsolete)
Don Olmstead
Comment 4 2020-01-16 14:02:07 PST
Created attachment 387954 [details] Patch
Ross Kirsling
Comment 5 2020-01-16 14:36:42 PST
Comment on attachment 387954 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=387954&action=review r=me with nits > Source/WebKit/Platform/unix/ModuleUnix.cpp:40 > +void* Module::platformFunctionPointer(const char* functionName) const Seems like we should recheck the newly-added files for unused param names like this one. > Source/WebKit/UIProcess/playstation/WebPageProxyPlayStation.cpp:43 > + return nullptr; // static_cast<PageClientImpl&>(pageClient()).viewBackend(); The commented-out code in this file seems like it should be removed.
Don Olmstead
Comment 6 2020-01-16 14:47:43 PST
Created attachment 387963 [details] Patch Fix the nits
WebKit Commit Bot
Comment 7 2020-01-16 15:15:04 PST
Comment on attachment 387963 [details] Patch Clearing flags on attachment: 387963 Committed r254713: <https://trac.webkit.org/changeset/254713>
WebKit Commit Bot
Comment 8 2020-01-16 15:15:06 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.