Bug 206186 - Share WebPreferences stub for ports without an implementation
Summary: Share WebPreferences stub for ports without an implementation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords: InRadar
Depends on:
Blocks: 205965
  Show dependency tree / graph
 
Reported: 2020-01-13 12:12 PST by Don Olmstead
Modified: 2020-01-14 17:41 PST (History)
11 users (show)

See Also:

Attachments
WIP Patch (13.18 KB, patch)
2020-01-13 12:46 PST, Don Olmstead 		no flags Details | Formatted Diff | Diff
Patch (18.67 KB, patch)
2020-01-13 13:49 PST, Don Olmstead 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2020-01-13 12:12:25 PST 
Currently only the Mac port implements the majority of the methods in WebPreferences that are platform specific.
Comment 1 Don Olmstead 2020-01-13 12:46:45 PST 
Created attachment 387560 [details]
WIP Patch

Just checking the build especially on iOS.
Comment 2 Don Olmstead 2020-01-13 13:49:15 PST 
Created attachment 387565 [details]
Patch

Moving around Apple code as well.
Comment 3 WebKit Commit Bot 2020-01-13 20:53:26 PST 
Comment on attachment 387565 [details]
Patch

Clearing flags on attachment: 387565

Committed r254489: <https://trac.webkit.org/changeset/254489>
Comment 4 WebKit Commit Bot 2020-01-13 20:53:28 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2020-01-13 20:54:15 PST 
<rdar://problem/58555943>