| Summary: | Fix testing Makefile to inherit preprocessor definitions | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Keith Miller <keith_miller> | ||||||||
| Component: | New Bugs | Assignee: | Keith Miller <keith_miller> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, mark.lam, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Keith Miller
2020-01-08 11:24:50 PST
Created attachment 387117 [details]
Patch
Created attachment 387119 [details]
Patch
Comment on attachment 387119 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=387119&action=review r=me with fix. > ChangeLog:17 > +2020-01-08 Keith Miller <keith_miller@apple.com> > + > + Fix testing Makefile to inherit preprocessor definitions > + https://bugs.webkit.org/show_bug.cgi?id=205940 > + > + Reviewed by NOBODY (OOPS!). > + > + * Makefile.shared: Remove dupe ChangeLog. Created attachment 387126 [details]
Patch for landing
The commit-queue encountered the following flaky tests while processing attachment 387126 [details]: fetch/fetch-worker-crash.html bug 187257 (author: youennf@gmail.com) The commit-queue is continuing to process your patch. Comment on attachment 387126 [details] Patch for landing Clearing flags on attachment: 387126 Committed r254219: <https://trac.webkit.org/changeset/254219> All reviewed patches have been landed. Closing bug. |