Summary: | Reformat WebFrameLoaderClient logging | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Keith Rollin <krollin> | ||||
Component: | WebKit Misc. | Assignee: | Keith Rollin <krollin> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bfulgham, cdumez, commit-queue, webkit-bug-importer, zalan | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=205679 | ||||||
Attachments: |
|
Description
Keith Rollin
2020-01-07 10:35:54 PST
Created attachment 386992 [details]
Patch
Comment on attachment 386992 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=386992&action=review r=me > Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:339 > + WEBFRAMELOADERCLIENT_RELEASE_LOG_FAULT(Loading, "dispatchDidReceiveServerRedirectForProvisionalLoad: Called with no provisional DocumentLoader (frameState=%i, stateForDebugging=%i)", m_frame->coreFrame()->loader().state(), m_frame->coreFrame()->loader().stateMachine().stateForDebugging()); This seems a little wordy, but I can't think of a better naming scheme. Comment on attachment 386992 [details] Patch Clearing flags on attachment: 386992 Committed r254147: <https://trac.webkit.org/changeset/254147> All reviewed patches have been landed. Closing bug. |