Bug 205840

Summary: check-webkit-style: bmalloc doesn't use config.h
Product: WebKit Reporter: Basuke Suzuki <basuke>
Component: Tools / TestsAssignee: Basuke Suzuki <basuke>
Status: RESOLVED FIXED    
Severity: Normal CC: basuke, commit-queue, ews-watchlist, glenn, jbedard, slewis, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 210734    
Attachments:
Description Flags
PATCH
none
PATCH
none
PATCH
jbedard: review+
PATCH none

Basuke Suzuki
Reported 2020-01-06 15:42:24 PST
It complains about [build/include_order] for bmalloc files. > $ Tools/Scripts/check-webkit-style Source/bmalloc/bmalloc/Heap.cpp > ERROR: Source/bmalloc/bmalloc/Heap.cpp:26: You should not add a blank line before implementation file's own header. [build/include_order] [4]
Attachments
PATCH (4.73 KB, patch)
2020-01-06 16:40 PST, Basuke Suzuki 		no flags
DetailsFormatted DiffDiff
PATCH (8.78 KB, patch)
2020-01-06 17:09 PST, Basuke Suzuki 		no flags
DetailsFormatted DiffDiff
PATCH (8.79 KB, patch)
2020-01-06 17:20 PST, Basuke Suzuki 		jbedard: review+
DetailsFormatted DiffDiff
PATCH (8.79 KB, patch)
2020-01-07 10:18 PST, Basuke Suzuki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Basuke Suzuki
Comment 1 2020-01-06 16:40:14 PST
Created attachment 386912 [details] PATCH
Basuke Suzuki
Comment 2 2020-01-06 17:09:46 PST
Created attachment 386916 [details] PATCH
Basuke Suzuki
Comment 3 2020-01-06 17:20:55 PST
Created attachment 386919 [details] PATCH wrong email address was used in ChangeLog.
Jonathan Bedard
Comment 4 2020-01-07 09:09:34 PST
Comment on attachment 386919 [details] PATCH View in context: https://bugs.webkit.org/attachment.cgi?id=386919&action=review > Tools/Scripts/webkitpy/style/checkers/cpp.py:312 > + has_config_header: Whether framework uses config.h or not. I don't think you mean framework here, I think this should just be 'Whether the header includes config.h'. bmalloc isn't a framework in the strictest sense, we could probably use 'project' too, I suppose.
Basuke Suzuki
Comment 5 2020-01-07 10:17:04 PST
(In reply to Jonathan Bedard from comment #4) > Comment on attachment 386919 [details] > PATCH > > View in context: > https://bugs.webkit.org/attachment.cgi?id=386919&action=review > > > Tools/Scripts/webkitpy/style/checkers/cpp.py:312 > > + has_config_header: Whether framework uses config.h or not. > > I don't think you mean framework here, I think this should just be 'Whether > the header includes config.h'. bmalloc isn't a framework in the strictest > sense, we could probably use 'project' too, I suppose. Yes, "project" seems reasonable. Thanks.
Basuke Suzuki
Comment 6 2020-01-07 10:18:54 PST
Created attachment 386987 [details] PATCH
WebKit Commit Bot
Comment 7 2020-01-07 11:04:08 PST
Comment on attachment 386987 [details] PATCH Clearing flags on attachment: 386987 Committed r254140: <https://trac.webkit.org/changeset/254140>
WebKit Commit Bot
Comment 8 2020-01-07 11:04:10 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2020-01-07 11:05:18 PST
<rdar://problem/58380310>
Note You need to log in before you can comment on or make changes to this bug.