Bug 205683

Summary: Reformat WebProcessCache logging
Product: WebKit Reporter: Keith Rollin <krollin>
Component: WebKit Misc.Assignee: Keith Rollin <krollin>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=205679
Attachments:
Description Flags
Patch none

Keith Rollin
Reported 2020-01-02 00:28:07 PST
Update the format used by WebProcessCache in its RELEASE_LOG logging. Use the format used by WebPageProxy and NetworkResourceLoader, which is generally of the form: <object-address> - [<values that help thread together operations>] <class>::<method>: <message and other useful values> So, for example: 0x1145ed208 - WebProcessCache::canCacheProcess(): Not caching process 83671 because it does not have an associated registrable domain becomes: 0x1145ed208 - [PID=83671] WebProcessCache::canCacheProcess: Not caching process because it does not have an associated registrable domain
Attachments
Patch (12.99 KB, patch)
2020-01-02 00:30 PST, Keith Rollin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-01-02 00:28:16 PST
<rdar://problem/58269352>
Keith Rollin
Comment 2 2020-01-02 00:30:02 PST
Created attachment 386598 [details] Patch
WebKit Commit Bot
Comment 3 2020-01-02 13:43:36 PST
Comment on attachment 386598 [details] Patch Clearing flags on attachment: 386598 Committed r253981: <https://trac.webkit.org/changeset/253981>
WebKit Commit Bot
Comment 4 2020-01-02 13:43:38 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.