Summary: | Import WPT test cases for apect-ratio generated from attribute width and height | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | cathiechen <cathiechen> | ||||||||||
Component: | DOM | Assignee: | cathiechen <cathiechen> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | clord, commit-queue, eric.carlson, ews-watchlist, fred.wang, glenn, jbedard, jer.noble, philipj, rego, sergio, simon.fraser, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | 205908 | ||||||||||||
Bug Blocks: | 201641 | ||||||||||||
Attachments: |
|
Description
cathiechen
2020-01-01 19:46:15 PST
Created attachment 386596 [details]
Patch
Hi, This patch import test cases for image aspect-ratio generated from attributes width and height. PTAL, thanks:) Created attachment 386597 [details]
Patch
Comment on attachment 386597 [details]
Patch
LGTM, please wait for EWSs before landing.
Created attachment 386599 [details]
Patch
Created attachment 386600 [details]
Patch
(In reply to Manuel Rego Casasnovas from comment #4) > Comment on attachment 386597 [details] > Patch > > LGTM, please wait for EWSs before landing. Done! Thanks:) Comment on attachment 386600 [details] Patch Clearing flags on attachment: 386600 Committed r253996: <https://trac.webkit.org/changeset/253996> All reviewed patches have been landed. Closing bug. Import broke a test on GTK: https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2F2dcontext%2Fimagebitmap%2Fcanvas-createImageBitmap-video-resize.html (In reply to Jonathan Bedard from comment #11) > Import broke a test on GTK: > https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb- > platform-tests%2F2dcontext%2Fimagebitmap%2Fcanvas-createImageBitmap-video- > resize.html That test is actually passing now in GTK, but it needs an updated -expected.txt result. That test is using "/media/video.ogv" which was not imported before, so it's expected that there's a change of behavior. However it seems to be failing yet on other platforms, clord@ could you check what's going on? Thanks! I tested it on Mac. It seems .ogv file is not supported, so `video.oncanplaythrough` wouldn't fire and it will get an timeout error. And .ogv is supported by WebKitGTK, so this test passes on GTK. |