Bug 205678

Summary: Import WPT test cases for apect-ratio generated from attribute width and height
Product: WebKit Reporter: cathiechen <cathiechen>
Component: DOMAssignee: cathiechen <cathiechen>
Status: RESOLVED FIXED    
Severity: Normal CC: clord, commit-queue, eric.carlson, ews-watchlist, fred.wang, glenn, jbedard, jer.noble, philipj, rego, sergio, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 205908    
Bug Blocks: 201641    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Description cathiechen 2020-01-01 19:46:15 PST
Import test cases from web-platform-tests/html/rendering/replaced-elements/attributes-for-embedded-content-and-images
Comment 1 cathiechen 2020-01-01 21:02:15 PST
Created attachment 386596 [details]
Patch
Comment 2 cathiechen 2020-01-01 21:14:36 PST
Hi,

This patch import test cases for image aspect-ratio generated from attributes width and height.

PTAL, thanks:)
Comment 3 cathiechen 2020-01-01 23:39:39 PST
Created attachment 386597 [details]
Patch
Comment 4 Manuel Rego Casasnovas 2020-01-02 00:38:05 PST
Comment on attachment 386597 [details]
Patch

LGTM, please wait for EWSs before landing.
Comment 5 cathiechen 2020-01-02 02:20:23 PST
Created attachment 386599 [details]
Patch
Comment 6 cathiechen 2020-01-02 03:03:08 PST
Created attachment 386600 [details]
Patch
Comment 7 cathiechen 2020-01-03 05:45:33 PST
(In reply to Manuel Rego Casasnovas from comment #4)
> Comment on attachment 386597 [details]
> Patch
> 
> LGTM, please wait for EWSs before landing.

Done! Thanks:)
Comment 8 WebKit Commit Bot 2020-01-03 06:18:20 PST
Comment on attachment 386600 [details]
Patch

Clearing flags on attachment: 386600

Committed r253996: <https://trac.webkit.org/changeset/253996>
Comment 9 WebKit Commit Bot 2020-01-03 06:18:21 PST
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2020-01-03 06:19:28 PST
<rdar://problem/58296773>
Comment 12 Manuel Rego Casasnovas 2020-01-07 21:47:45 PST
(In reply to Jonathan Bedard from comment #11)
> Import broke a test on GTK:
> https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-
> platform-tests%2F2dcontext%2Fimagebitmap%2Fcanvas-createImageBitmap-video-
> resize.html

That test is actually passing now in GTK, but it needs an updated -expected.txt result.
That test is using "/media/video.ogv" which was not imported before, so it's expected that there's a change of behavior.

However it seems to be failing yet on other platforms, clord@ could you check what's going on? Thanks!
Comment 13 cathiechen 2020-01-07 23:25:11 PST
I tested it on Mac. It seems .ogv file is not supported, so `video.oncanplaythrough` wouldn't fire and it will get an timeout error.

And .ogv is supported by WebKitGTK, so this test passes on GTK.