Bug 205342

Summary: Re-sync web-platform-tests/common from upstream
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Tools / TestsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, clord, commit-queue, fred.wang, ggaren, rniwa, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 205343, 205352, 205354, 205445    
Bug Blocks:    
Attachments:
Description Flags
WIP Patch
none
WIP Patch
none
WIP Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2019-12-17 08:49:54 PST
Re-sync web-platform-tests/common from upstream.
Attachments
WIP Patch (276.63 KB, patch)
2019-12-17 08:50 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
WIP Patch (276.63 KB, patch)
2019-12-17 12:21 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
WIP Patch (285.48 KB, patch)
2019-12-17 13:42 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (290.94 KB, patch)
2019-12-17 18:38 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (291.88 KB, patch)
2019-12-17 19:18 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2019-12-17 08:50:43 PST
Created attachment 385895 [details] WIP Patch
Chris Dumez
Comment 2 2019-12-17 12:21:20 PST
Created attachment 385908 [details] WIP Patch
Chris Dumez
Comment 3 2019-12-17 13:42:15 PST
Created attachment 385917 [details] WIP Patch
Chris Dumez
Comment 4 2019-12-17 18:38:19 PST
Created attachment 385933 [details] Patch
Chris Dumez
Comment 5 2019-12-17 19:18:40 PST
Created attachment 385935 [details] Patch
Frédéric Wang (:fredw)
Comment 6 2019-12-18 00:42:03 PST
Comment on attachment 385935 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385935&action=review > LayoutTests/canvas/philip/tests/2d.drawImage.incomplete.emptysrc.html:7 > +<link rel="stylesheet" href="../../../imported/w3c/web-platform-tests/2dcontext/resources/canvas-tests.css"> I noticed that these tests currently rely on imported/w3c/web-platform-tests resources. Although your patch does not change the situation, I think there has been some controversy in the past when relying on WPT (bug 179769) so it might be worth checking with your colleagues.
WebKit Commit Bot
Comment 7 2019-12-18 07:49:09 PST
Comment on attachment 385935 [details] Patch Clearing flags on attachment: 385935 Committed r253683: <https://trac.webkit.org/changeset/253683>
WebKit Commit Bot
Comment 8 2019-12-18 07:49:11 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2019-12-18 07:50:21 PST
<rdar://problem/58042926>
Chris Lord
Comment 10 2019-12-19 04:18:16 PST
This commit has broken all offscreen-canvas tests, which used the canvas-related files in LayoutTests/imported/w3c/web-platform-tests/common/ that were deleted by this patch. I guess updating the affected tests will fix this(?)
Frédéric Wang (:fredw)
Comment 11 2019-12-19 04:33:13 PST
(In reply to Chris Lord from comment #10) > This commit has broken all offscreen-canvas tests, which used the > canvas-related files in LayoutTests/imported/w3c/web-platform-tests/common/ > that were deleted by this patch. I guess updating the affected tests will > fix this(?) Yeah I had concern about this change in comment 6. Maybe as a quick solution you can upload a patch to put back the deleted file? Or otherwise as I you suggested, update the affected tests.
Carlos Alberto Lopez Perez
Comment 12 2019-12-19 04:37:33 PST
(In reply to Chris Lord from comment #10) > This commit has broken all offscreen-canvas tests, which used the > canvas-related files in LayoutTests/imported/w3c/web-platform-tests/common/ > that were deleted by this patch. I guess updating the affected tests will > fix this(?) I will mark all those tests to bug 205445
Chris Dumez
Comment 13 2019-12-19 07:06:56 PST
I think we should resync the offscreen-canvas tests then.
Chris Lord
Comment 14 2019-12-19 07:09:48 PST
(In reply to Chris Dumez from comment #13) > I think we should resync the offscreen-canvas tests then. Doing so in bug 205445.
Chris Dumez
Comment 15 2019-12-19 07:14:47 PST
(In reply to Chris Lord from comment #14) > (In reply to Chris Dumez from comment #13) > > I think we should resync the offscreen-canvas tests then. > > Doing so in bug 205445. Thanks. I am guessing those tests are skipped on Apple platforms and that’s why I missed them, sorry about that.
Note You need to log in before you can comment on or make changes to this bug.