Bug 205321

Summary: [cairo] text-align:justify layouts texts wrongly for complex texts
Product: WebKit Reporter: Fujii Hironori <Hironori.Fujii>
Component: PlatformAssignee: Fujii Hironori <Hironori.Fujii>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, don.olmstead, ews-watchlist, mmaxfield, ross.kirsling, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=53184
Attachments:
Description Flags
justify-ideograph-complex-actual.png
none
Patch cgarcia: review+

Description Fujii Hironori 2019-12-16 19:27:04 PST 
In Source/WebCore/platform/graphics/cairo/FontCairoHarfbuzzNG.cpp, canExpandAroundIdeographsInComplexText return false.

> bool FontCascade::canExpandAroundIdeographsInComplexText()
> {
>     return false;
> }

However, ComplexTextController doesn't take it into account.

fast/text/justify-ideograph-complex.html is a test case.
Comment 1 Fujii Hironori 2019-12-16 19:28:28 PST 
Created attachment 385847 [details]
justify-ideograph-complex-actual.png
Comment 2 Fujii Hironori 2019-12-16 19:49:18 PST 
The tests and code have come from Bug 53184.
Comment 3 Fujii Hironori 2019-12-16 20:19:43 PST 
Created attachment 385849 [details]
Patch
Comment 4 Carlos Garcia Campos 2019-12-17 00:50:56 PST 
Comment on attachment 385849 [details]
Patch

Thanks!
Comment 5 Fujii Hironori 2019-12-17 18:19:07 PST 
Committed r253664: <https://trac.webkit.org/changeset/253664>
Comment 6 Radar WebKit Bug Importer 2019-12-17 18:20:35 PST 
<rdar://problem/58029006>