Bug 205293

Summary: Fix btjs on current lldb
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, jbedard, mark.lam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Keith Miller
Reported 2019-12-16 12:19:34 PST
Fix btjs on current lldb
Attachments
Patch (3.84 KB, patch)
2019-12-16 12:19 PST, Keith Miller 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2019-12-16 12:19:53 PST
Created attachment 385793 [details] Patch
Mark Lam
Comment 2 2019-12-16 12:22:40 PST
Comment on attachment 385793 [details] Patch r=me
WebKit Commit Bot
Comment 3 2019-12-16 12:58:52 PST
Comment on attachment 385793 [details] Patch Clearing flags on attachment: 385793 Committed r253572: <https://trac.webkit.org/changeset/253572>
WebKit Commit Bot
Comment 4 2019-12-16 12:58:53 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2019-12-16 12:59:18 PST
<rdar://problem/57981841>
Alexey Proskuryakov
Comment 6 2019-12-16 13:23:06 PST
We have tests for lldb_webkit, can one be added here?
Keith Miller
Comment 7 2019-12-16 13:30:53 PST
(In reply to Alexey Proskuryakov from comment #6) > We have tests for lldb_webkit, can one be added here? I couldn't figure out how to get the tests to run. Do we run them in automation?
Jonathan Bedard
Comment 8 2019-12-16 13:51:27 PST
(In reply to Keith Miller from comment #7) > (In reply to Alexey Proskuryakov from comment #6) > > We have tests for lldb_webkit, can one be added here? > > I couldn't figure out how to get the tests to run. Do we run them in > automation? There is a script, test-lldb-webkit. No, they are not currently run in automation, but that is imminently changing (waiting on https://bugs.webkit.org/show_bug.cgi?id=205271 to land)
Note You need to log in before you can comment on or make changes to this bug.