Bug 205271

Summary: lldbwebkittester: Conform with testing binary format
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, slewis, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=187916
https://bugs.webkit.org/show_bug.cgi?id=205315
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Jonathan Bedard
Reported 2019-12-16 07:32:38 PST
lldbwebkittester should be built with all our other tooling.
Attachments
Patch (1.89 KB, patch)
2019-12-16 07:35 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (1.76 KB, patch)
2019-12-16 08:55 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.94 KB, patch)
2019-12-16 13:39 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2019-12-16 07:35:11 PST
Created attachment 385764 [details] Patch
Jonathan Bedard
Comment 2 2019-12-16 08:55:03 PST
Created attachment 385772 [details] Patch
Alexey Proskuryakov
Comment 3 2019-12-16 10:54:56 PST
Comment on attachment 385772 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385772&action=review > Tools/ChangeLog:8 > + lldbwebkittester should be built the same way ImageDiff, TestWebKitAPI and WebKitTestRunner are. I think that it would be helpful to elaborate more. In addition to consistency, this paves the way to testing lldb scripts against WebCore and WebKit in the future, which would be a non-starter if build-lldbwebkittester was expected to rebuild everything. > Tools/ChangeLog:11 > + * Scripts/build-webkit: Does make build it already? build-webkit should be consistent with make too.
Jonathan Bedard
Comment 4 2019-12-16 11:23:02 PST
Comment on attachment 385772 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385772&action=review >> Tools/ChangeLog:11 >> + * Scripts/build-webkit: > > Does make build it already? build-webkit should be consistent with make too. Make does already build it, at least in WebKit. Verifying that this is actually the case now.
Jonathan Bedard
Comment 5 2019-12-16 13:39:55 PST
Created attachment 385804 [details] Patch for landing
WebKit Commit Bot
Comment 6 2019-12-16 14:25:00 PST
Comment on attachment 385804 [details] Patch for landing Clearing flags on attachment: 385804 Committed r253577: <https://trac.webkit.org/changeset/253577>
WebKit Commit Bot
Comment 7 2019-12-16 14:25:02 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2019-12-16 14:26:40 PST
<rdar://problem/57985186>
Note You need to log in before you can comment on or make changes to this bug.