Summary: | Add an option to capture audio in GPU process | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||
Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, eric.carlson, ews-watchlist, glenn, hta, jer.noble, mkwst, philipj, sergio, tommyw, webkit-bug-importer, youennf | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
youenn fablet
2019-12-09 05:19:21 PST
Created attachment 385144 [details]
Patch
Comment on attachment 385144 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385144&action=review > Source/WebKit/Shared/WebPreferences.yaml:1701 > +CaptureAudioInGPUProcessEnabled: > + type: bool > + defaultValue: false > + humanReadableName: "Capture audio in GPUProcess" > + humanReadableDescription: "Capture audio in GPUProcess" > + category: experimental > + webcoreBinding: none > + condition: ENABLE(MEDIA_STREAM) See Tim's comment in https://bugs.webkit.org/show_bug.cgi?id=204801 - this should be an internal feature and should have a name like "useGPUProcessForAudioCapture". (In reply to Eric Carlson from comment #2) > Comment on attachment 385144 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=385144&action=review > > > Source/WebKit/Shared/WebPreferences.yaml:1701 > > +CaptureAudioInGPUProcessEnabled: > > + type: bool > > + defaultValue: false > > + humanReadableName: "Capture audio in GPUProcess" > > + humanReadableDescription: "Capture audio in GPUProcess" > > + category: experimental > > + webcoreBinding: none > > + condition: ENABLE(MEDIA_STREAM) > > See Tim's comment in https://bugs.webkit.org/show_bug.cgi?id=204801 - this > should be an internal feature and should have a name like > "useGPUProcessForAudioCapture". OK for internals for now. I think it should not take too long to allow audio capture in GPUProcess so that might be a good candidate for STP soon. As of the naming, we already have CaptureAudioInUIProcess so I prefer keeping CaptureAudioInGPUProcess. It also seems easy to read. Created attachment 385147 [details]
Patch
Comment on attachment 385147 [details] Patch Clearing flags on attachment: 385147 Committed r253288: <https://trac.webkit.org/changeset/253288> All reviewed patches have been landed. Closing bug. |