Bug 205007

Summary: Add an option to capture audio in GPU process
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, ews-watchlist, glenn, hta, jer.noble, mkwst, philipj, sergio, tommyw, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

youenn fablet
Reported 2019-12-09 05:19:21 PST
Add an option to capture audio in GPU process
Attachments
Patch (26.11 KB, patch)
2019-12-09 05:25 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (26.11 KB, patch)
2019-12-09 06:10 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2019-12-09 05:25:23 PST
Created attachment 385144 [details] Patch
Eric Carlson
Comment 2 2019-12-09 06:04:25 PST
Comment on attachment 385144 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385144&action=review > Source/WebKit/Shared/WebPreferences.yaml:1701 > +CaptureAudioInGPUProcessEnabled: > + type: bool > + defaultValue: false > + humanReadableName: "Capture audio in GPUProcess" > + humanReadableDescription: "Capture audio in GPUProcess" > + category: experimental > + webcoreBinding: none > + condition: ENABLE(MEDIA_STREAM) See Tim's comment in https://bugs.webkit.org/show_bug.cgi?id=204801 - this should be an internal feature and should have a name like "useGPUProcessForAudioCapture".
youenn fablet
Comment 3 2019-12-09 06:09:15 PST
(In reply to Eric Carlson from comment #2) > Comment on attachment 385144 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=385144&action=review > > > Source/WebKit/Shared/WebPreferences.yaml:1701 > > +CaptureAudioInGPUProcessEnabled: > > + type: bool > > + defaultValue: false > > + humanReadableName: "Capture audio in GPUProcess" > > + humanReadableDescription: "Capture audio in GPUProcess" > > + category: experimental > > + webcoreBinding: none > > + condition: ENABLE(MEDIA_STREAM) > > See Tim's comment in https://bugs.webkit.org/show_bug.cgi?id=204801 - this > should be an internal feature and should have a name like > "useGPUProcessForAudioCapture". OK for internals for now. I think it should not take too long to allow audio capture in GPUProcess so that might be a good candidate for STP soon. As of the naming, we already have CaptureAudioInUIProcess so I prefer keeping CaptureAudioInGPUProcess. It also seems easy to read.
youenn fablet
Comment 4 2019-12-09 06:10:35 PST
Created attachment 385147 [details] Patch
WebKit Commit Bot
Comment 5 2019-12-09 07:36:49 PST
Comment on attachment 385147 [details] Patch Clearing flags on attachment: 385147 Committed r253288: <https://trac.webkit.org/changeset/253288>
WebKit Commit Bot
Comment 6 2019-12-09 07:36:51 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-12-09 07:37:43 PST
<rdar://problem/57751825>
Note You need to log in before you can comment on or make changes to this bug.