Bug 205004

Summary:

Remove behavior that makes <br> boxes 0-height in quirks mode

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, eric.carlson, esprehn+autocc, ews-watchlist, glenn, jer.noble, kondapallykalyan, mmaxfield, pdr, philipj, sergio, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
wip	none
wip	none
patch	none
patch	zalan: review+, commit-queue: commit-queue-
patch	none

Antti Koivisto

Reported 2019-12-09 00:56:51 PST

It appears to exist purely to avoid rebasing test results.

Attachments
wip (2.00 MB, patch) 2019-12-09 00:57 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
wip (32.34 KB, patch) 2019-12-10 02:29 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
patch (54.52 KB, patch) 2019-12-10 04:57 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
patch (54.52 KB, patch) 2019-12-10 05:39 PST, Antti Koivisto	zalan: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
patch (54.45 KB, patch) 2019-12-10 08:13 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Antti Koivisto

Comment 1 2019-12-09 00:57:54 PST

Created attachment 385138 [details] wip

Antti Koivisto

Comment 2 2019-12-10 02:29:41 PST

Created attachment 385245 [details] wip

Antti Koivisto

Comment 3 2019-12-10 04:57:25 PST

Created attachment 385251 [details] patch

Antti Koivisto

Comment 4 2019-12-10 05:39:28 PST

Created attachment 385252 [details] patch

zalan

Comment 5 2019-12-10 06:51:00 PST

Comment on attachment 385252 [details] patch Let's see what it breaks.

Antti Koivisto

Comment 6 2019-12-10 07:00:53 PST

Bot watchers: if this affects results in other bots it can be dealt by rebasing.

WebKit Commit Bot

Comment 7 2019-12-10 07:41:39 PST

Comment on attachment 385252 [details] patch Rejecting attachment 385252 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 385252, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 5000 characters of output: /platform/mac/fast/text/svg-font-face-with-kerning-expected.txt patching file LayoutTests/platform/mac/fast/writing-mode/border-styles-vertical-lr-expected.txt patching file LayoutTests/platform/mac/fast/writing-mode/english-bt-text-expected.txt patching file LayoutTests/platform/mac/fast/writing-mode/text-orientation-basic-expected.txt patching file LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug56024-expected.txt patching file LayoutTests/platform/win/fast/text/international/bidi-layout-across-linebreak-expected.txt patching file LayoutTests/platform/win/fast/writing-mode/english-bt-text-expected.txt patching file LayoutTests/platform/win/fast/writing-mode/text-orientation-basic-expected.txt patching file LayoutTests/platform/win/tables/mozilla_expected_failures/bugs/bug56024-expected.txt patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/rendering/InlineBox.cpp patching file Source/WebCore/rendering/RenderLineBreak.cpp patching file Source/WebCore/rendering/RenderLineBreak.h patching file Source/WebCore/rendering/RenderTreeAsText.cpp patching file Source/WebCore/rendering/SimpleLineLayoutResolver.cpp patching file Source/WebCore/rendering/SimpleLineLayoutResolver.h patching file Source/WebCore/rendering/line/LineLayoutTraversal.h patching file Source/WebCore/rendering/line/LineLayoutTraversalComplexPath.h patching file Source/WebCore/rendering/line/LineLayoutTraversalDisplayRunPath.h Hunk #1 FAILED at 58. 1 out of 3 hunks FAILED -- saving rejects to file Source/WebCore/rendering/line/LineLayoutTraversalDisplayRunPath.h.rej patching file Source/WebCore/rendering/line/LineLayoutTraversalSimplePath.h Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Zalan Bujtas']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 28 diffs from patch file(s). patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/fast/multicol/pagination-h-horizontal-bt-expected.txt patching file LayoutTests/fast/multicol/pagination-v-horizontal-bt-expected.txt patching file LayoutTests/fast/ruby/position-after-expected.txt patching file LayoutTests/platform/ios/fast/writing-mode/border-styles-vertical-lr-expected.txt patching file LayoutTests/platform/ios/fast/writing-mode/english-bt-text-expected.txt patching file LayoutTests/platform/ios/tables/mozilla_expected_failures/bugs/bug56024-expected.txt patching file LayoutTests/platform/mac/fast/text/international/bidi-layout-across-linebreak-expected.txt patching file LayoutTests/platform/mac/fast/text/svg-font-face-with-kerning-expected.txt patching file LayoutTests/platform/mac/fast/writing-mode/border-styles-vertical-lr-expected.txt patching file LayoutTests/platform/mac/fast/writing-mode/english-bt-text-expected.txt patching file LayoutTests/platform/mac/fast/writing-mode/text-orientation-basic-expected.txt patching file LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug56024-expected.txt patching file LayoutTests/platform/win/fast/text/international/bidi-layout-across-linebreak-expected.txt patching file LayoutTests/platform/win/fast/writing-mode/english-bt-text-expected.txt patching file LayoutTests/platform/win/fast/writing-mode/text-orientation-basic-expected.txt patching file LayoutTests/platform/win/tables/mozilla_expected_failures/bugs/bug56024-expected.txt patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/rendering/InlineBox.cpp patching file Source/WebCore/rendering/RenderLineBreak.cpp patching file Source/WebCore/rendering/RenderLineBreak.h patching file Source/WebCore/rendering/RenderTreeAsText.cpp patching file Source/WebCore/rendering/SimpleLineLayoutResolver.cpp patching file Source/WebCore/rendering/SimpleLineLayoutResolver.h patching file Source/WebCore/rendering/line/LineLayoutTraversal.h patching file Source/WebCore/rendering/line/LineLayoutTraversalComplexPath.h patching file Source/WebCore/rendering/line/LineLayoutTraversalDisplayRunPath.h Hunk #1 FAILED at 58. 1 out of 3 hunks FAILED -- saving rejects to file Source/WebCore/rendering/line/LineLayoutTraversalDisplayRunPath.h.rej patching file Source/WebCore/rendering/line/LineLayoutTraversalSimplePath.h Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Zalan Bujtas']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Updating OpenSource From https://git.webkit.org/git/WebKit 44a08ff1186..f9d4af573b1 master -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 253323 = 44a08ff11860afed0a012f1eb0eab16bcd5e5ced r253324 = f9d4af573b161408b88692aa1619d2b3c3b1ed48 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: https://webkit-queues.webkit.org/results/13289105

Antti Koivisto

Comment 8 2019-12-10 08:13:26 PST

Created attachment 385262 [details] patch

WebKit Commit Bot

Comment 9 2019-12-10 08:57:52 PST

Comment on attachment 385262 [details] patch Clearing flags on attachment: 385262 Committed r253326: <https://trac.webkit.org/changeset/253326>

WebKit Commit Bot

Comment 10 2019-12-10 08:57:54 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 11 2019-12-10 08:59:07 PST

<rdar://problem/57795359>

Note You need to log in before you can comment on or make changes to this bug.