Bug 204950

Summary: Reduce timeout for page to handle beforeunload events when trying to close a page
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, commit-queue, ggaren, rniwa, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 206366, 207121    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2019-12-06 09:03:15 PST
Reduce timeout for page to handle beforeunload events when trying to close a page. It may currently take up to 3 seconds to actually close a tab after the user clicks on the "X" to close it. This is because we wait for the page to fire and handle the beforeunload events and only give up after 3 seconds. I propose we reduce this timeout to something more reasonable from a user standpoint (e.g. 500ms, no more than 1 second).
Attachments
Patch (5.09 KB, patch)
2019-12-06 09:08 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-12-06 09:03:34 PST
<rdar://problem/57700419>
Chris Dumez
Comment 2 2019-12-06 09:08:15 PST
Created attachment 385021 [details] Patch
WebKit Commit Bot
Comment 3 2019-12-06 15:02:18 PST
Comment on attachment 385021 [details] Patch Clearing flags on attachment: 385021 Committed r253224: <https://trac.webkit.org/changeset/253224>
WebKit Commit Bot
Comment 4 2019-12-06 15:02:19 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.