Summary: | Use default implementation for JSVALUE64 with GCC on unknown platform. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eike Rathke <erack> | ||||||||
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | berto, commit-queue, ews-watchlist, jbedard, jlewis3, keith_miller, mark.lam, msaboff, saam, simon.fraser, tsavell, tzagallo, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Eike Rathke
2019-11-29 06:54:00 PST
Created attachment 384504 [details]
Patch
Created attachment 384505 [details]
Patch
Grml.. webkit-patch insists on including it's on modification to force python2 even if already committed. I'll resubmit a manual patch. Created attachment 384506 [details]
Patch
Note: the style checker seems to be wrong in its analysis. Comment on attachment 384506 [details]
Patch
r=me
Comment on attachment 384506 [details] Patch Clearing flags on attachment: 384506 Committed r252949: <https://trac.webkit.org/changeset/252949> All reviewed patches have been landed. Closing bug. *** Bug 204643 has been marked as a duplicate of this bug. *** I think this broke Windows jsc tests: https://build.webkit.org/builders/Apple%20Win%2010%20Debug%20%28Tests%29?numbuilds=200 We don't have a super great range, unfortunately, since the build was broken, but this its the only commit which touched JSC stuff in https://results.webkit.org/commits?before_id=252951&after_id=252943 Only if the Windows build suddenly uses GCC on a non-x86-64 platform.. (In reply to Eike Rathke from comment #12) > Only if the Windows build suddenly uses GCC on a non-x86-64 platform.. That's what Saam said. Mark is looking into it (or at least was yesterday), even taking a deeper dive into the commits in our regression range, I don't see another commit that even touches JSC. |