Bug 204643
| Summary: | [GTK] [2.27.3] GCMemoryOperations.h: Unknown architecture | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Alberto Garcia <berto> |
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | bugs-noreply, cgarcia, mark.lam, ysuzuki |
| Priority: | P2 | ||
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Alberto Garcia
The latest development release of WebKitGTK fails to build in several
non-major architectures (mips64el, ppc64el, s390x, ...):
../Source/JavaScriptCore/heap/GCMemoryOperations.h:125:2: error: #error "Unknown architecture."
125 | #error "Unknown architecture."
A quick look suggests that functions like gcSafeMemcpy() and possibly
others have fast implementations in x86_64 and arm64 but fall back to
a slower memcpy implementation in other cases.
The detection of when to use the slow path seems to be incorrect,
hence the error.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Yusuke Suzuki
We should add ENABLE_CONCURRENT_GC in Platform.h, and enable it only for X64 / ARM64.
And we should also ensure USE_CONCURRENT_JS is enabled in x64 / ARM64. Then, we should use regular memset/memcpy for non concurrent environment.
Alberto Garcia
*** This bug has been marked as a duplicate of bug 204701 ***