Bug 204420

Summary: run-webkit-tests rebuilds ImageDiff every time
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, ews-watchlist, glenn, jbedard, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Alexey Proskuryakov
Reported 2019-11-20 13:06:40 PST
Every time I run run-webkit-tests --ios-simulator, I get this error, and ImageDiff gets rebuilt. 12:52:45.307 72842 Checking build ... 12:52:45.309 72842 ImageDiff was not found at /Users/ap/Safari/OpenSource/WebKitBuild/Release-iphonesimulator/ImageDiff This path is incorrect, as ImageDiff is not a simulator project, it's built into Release/ImageDiff
Attachments
Patch (5.59 KB, patch)
2020-09-04 13:26 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2020-09-02 21:20:44 PDT
*** Bug 216100 has been marked as a duplicate of this bug. ***
Darin Adler
Comment 2 2020-09-02 21:21:27 PDT
<rdar://problem/68232690>
Jonathan Bedard
Comment 3 2020-09-04 13:26:59 PDT
Created attachment 408015 [details] Patch
Jonathan Bedard
Comment 4 2020-09-04 13:30:29 PDT
Comment on attachment 408015 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408015&action=review > Tools/Scripts/webkitpy/port/base.py:278 > + image_diff_path = self._path_to_image_diff() Tim Horton's original point that _path_to_image_diff is memoized, is true, kind of, but not for Apple's ports. We really need to memoize _path_to_image_diff in all children classes, and then explicitly clear the memoization after building.
EWS
Comment 5 2020-09-04 14:44:33 PDT
Committed r266638: <https://trac.webkit.org/changeset/266638> All reviewed patches have been landed. Closing bug and clearing flags on attachment 408015 [details].
Note You need to log in before you can comment on or make changes to this bug.