Bug 20437

Summary: Clean XMLTokenizer by separating the Qt and Libxml2 implementation
Product: WebKit Reporter: Holger Freyther <zecke>
Component: XMLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: lars.knoll
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Start separating XMLTokenizer mrowe: review+

Holger Freyther
Reported 2008-08-18 16:40:29 PDT
The current XMLTokenizer.cpp is hard to read as two separate implementations are in one file. Separating the Qt and libxml2 implementation should make it more readable.
Attachments
Start separating XMLTokenizer (132.82 KB, patch)
2008-08-18 17:04 PDT, Holger Freyther 		mrowe: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Holger Freyther
Comment 1 2008-08-18 17:04:56 PDT
Created attachment 22867 [details] Start separating XMLTokenizer Keep common code in XMLTokenizer.cpp, move Qt code to XMLTokenizerQt.cpp and the rest to XMLTokenizerLibxml2.cpp. Comments appreciated.
Mark Rowe (bdash)
Comment 2 2008-08-18 19:10:42 PDT
It might be a good idea to create the two new .cpp files by doing an "svn cp" of XMLTokenizer.cpp then removing the unneeded bits. That would help make it obvious what has happened in the SVN history.
Mark Rowe (bdash)
Comment 3 2008-08-19 20:52:35 PDT
Should also change USE_QXMLSTREAM to the USE(QXMLSTREAM) style that we use for these sorts of things elsewhere.
Mark Rowe (bdash)
Comment 4 2008-08-19 22:24:44 PDT
Oh, and the new file will need to be added to the Mac, Windows and Wx project files too.
Mark Rowe (bdash)
Comment 5 2008-08-19 22:25:37 PDT
Comment on attachment 22867 [details] Start separating XMLTokenizer r=me, if you address the comments I made above, and add a ChangeLog entry.
Holger Freyther
Comment 6 2008-09-18 17:18:54 PDT
I think I addressed all the points and landed this patch. The size of the patch is a bit worrying but it looked good.
Simon Hausmann
Comment 7 2009-11-21 01:27:00 PST
*** Bug 14791 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.