Bug 204251

Summary: Improve WebAuthn NFC tests after r252297
Product: WebKit Reporter: Truitt Savell <tsavell>
Component: Tools / TestsAssignee: Jiewen Tan <jiewen_tan>
Status: RESOLVED FIXED    
Severity: Normal CC: alex.gaynor, bfulgham, commit-queue, jiewen_tan, keith_miller, webkit-bot-watchers-bugzilla, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=204024
Attachments:
Description Flags
Patch
none
Patch none

Description Truitt Savell 2019-11-15 14:27:13 PST 
http/wpt/webauthn/public-key-credential-create-success-nfc.https.html

This test has been Failing on Catalina

Reason:
This test began failing on Catalina sense https://trac.webkit.org/changeset/252298/webkit
History shows this began failing at that revision


History:
https://results.webkit.org/?suite=layout-tests&test=http%2Fwpt%2Fwebauthn%2Fpublic-key-credential-create-success-nfc.https.html


Diff:
--- /Volumes/Data/slave/catalina-debug-tests-wk2/build/layout-test-results/http/wpt/webauthn/public-key-credential-create-success-nfc.https-expected.txt
+++ /Volumes/Data/slave/catalina-debug-tests-wk2/build/layout-test-results/http/wpt/webauthn/public-key-credential-create-success-nfc.https-actual.txt
@@ -1,8 +1,10 @@
+
+Harness Error (TIMEOUT), message = null
 
 PASS PublicKeyCredential's [[create]] with minimum options in a mock nfc authenticator. 
 PASS PublicKeyCredential's [[create]] with authenticatorSelection { 'cross-platform' } in a mock nfc authenticator. 
 PASS PublicKeyCredential's [[create]] with multiple tags in a mock nfc authenticator. 
 PASS PublicKeyCredential's [[create]] with U2F in a mock nfc authenticator. 
 PASS PublicKeyCredential's [[create]] with multiple physical tags in a mock nfc authenticator. 
-PASS PublicKeyCredential's [[create]] with service restart in a mock nfc authenticator. 
+TIMEOUT PublicKeyCredential's [[create]] with service restart in a mock nfc authenticator. Test timed out
Comment 1 Yusuke Suzuki 2019-11-15 14:32:05 PST 
I think this is related to r252297.
Comment 2 Truitt Savell 2019-11-15 15:03:22 PST 
(In reply to Yusuke Suzuki from comment #1)
> I think this is related to r252297.

I agree with that. history did not have results for that commit so I didn't look at it.
Comment 3 Jiewen Tan 2019-11-15 16:42:03 PST 
Created attachment 383665 [details]
Patch
Comment 4 Jiewen Tan 2019-11-15 16:53:33 PST 
Created attachment 383666 [details]
Patch
Comment 5 Alexey Proskuryakov 2019-11-19 16:40:04 PST 
Comment on attachment 383666 [details]
Patch

rs=me
Comment 6 Jiewen Tan 2019-11-19 16:50:23 PST 
Comment on attachment 383666 [details]
Patch

Thanks Alexey for r+ this patch.
Comment 7 WebKit Commit Bot 2019-11-19 17:35:27 PST 
Comment on attachment 383666 [details]
Patch

Clearing flags on attachment: 383666

Committed r252668: <https://trac.webkit.org/changeset/252668>
Comment 8 WebKit Commit Bot 2019-11-19 17:35:28 PST 
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2019-11-19 17:36:16 PST 
<rdar://problem/57344037>