Bug 204251 - Improve WebAuthn NFC tests after r252297
Summary: Improve WebAuthn NFC tests after r252297
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jiewen Tan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-15 14:27 PST by Truitt Savell
Modified: 2019-11-19 17:36 PST (History)
8 users (show)

See Also:

Attachments
Patch (6.83 KB, patch)
2019-11-15 16:42 PST, Jiewen Tan 		no flags Details | Formatted Diff | Diff
Patch (6.78 KB, patch)
2019-11-15 16:53 PST, Jiewen Tan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Truitt Savell 2019-11-15 14:27:13 PST 
http/wpt/webauthn/public-key-credential-create-success-nfc.https.html

This test has been Failing on Catalina

Reason:
This test began failing on Catalina sense https://trac.webkit.org/changeset/252298/webkit
History shows this began failing at that revision


History:
https://results.webkit.org/?suite=layout-tests&test=http%2Fwpt%2Fwebauthn%2Fpublic-key-credential-create-success-nfc.https.html


Diff:
--- /Volumes/Data/slave/catalina-debug-tests-wk2/build/layout-test-results/http/wpt/webauthn/public-key-credential-create-success-nfc.https-expected.txt
+++ /Volumes/Data/slave/catalina-debug-tests-wk2/build/layout-test-results/http/wpt/webauthn/public-key-credential-create-success-nfc.https-actual.txt
@@ -1,8 +1,10 @@
+
+Harness Error (TIMEOUT), message = null
 
 PASS PublicKeyCredential's [[create]] with minimum options in a mock nfc authenticator. 
 PASS PublicKeyCredential's [[create]] with authenticatorSelection { 'cross-platform' } in a mock nfc authenticator. 
 PASS PublicKeyCredential's [[create]] with multiple tags in a mock nfc authenticator. 
 PASS PublicKeyCredential's [[create]] with U2F in a mock nfc authenticator. 
 PASS PublicKeyCredential's [[create]] with multiple physical tags in a mock nfc authenticator. 
-PASS PublicKeyCredential's [[create]] with service restart in a mock nfc authenticator. 
+TIMEOUT PublicKeyCredential's [[create]] with service restart in a mock nfc authenticator. Test timed out
Comment 1 Yusuke Suzuki 2019-11-15 14:32:05 PST 
I think this is related to r252297.
Comment 2 Truitt Savell 2019-11-15 15:03:22 PST 
(In reply to Yusuke Suzuki from comment #1)
> I think this is related to r252297.

I agree with that. history did not have results for that commit so I didn't look at it.
Comment 3 Jiewen Tan 2019-11-15 16:42:03 PST 
Created attachment 383665 [details]
Patch
Comment 4 Jiewen Tan 2019-11-15 16:53:33 PST 
Created attachment 383666 [details]
Patch
Comment 5 Alexey Proskuryakov 2019-11-19 16:40:04 PST 
Comment on attachment 383666 [details]
Patch

rs=me
Comment 6 Jiewen Tan 2019-11-19 16:50:23 PST 
Comment on attachment 383666 [details]
Patch

Thanks Alexey for r+ this patch.
Comment 7 WebKit Commit Bot 2019-11-19 17:35:27 PST 
Comment on attachment 383666 [details]
Patch

Clearing flags on attachment: 383666

Committed r252668: <https://trac.webkit.org/changeset/252668>
Comment 8 WebKit Commit Bot 2019-11-19 17:35:28 PST 
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2019-11-19 17:36:16 PST 
<rdar://problem/57344037>