Bug 204125

Summary:

[SVG2] Remove requiredFeatures from SVGTests

Product:

WebKit

Reporter:

Said Abou-Hallawa <sabouhallawa>

Component:

SVG

Assignee:

Ahmad Saleem <ahmad.saleem792>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ahmad.saleem792, berto, cdumez, cgarcia, dino, esprehn+autocc, ews-watchlist, fmalita, fred.wang, gustavo, gyuyoung.kim, heycam, kondapallykalyan, ntim, pdr, rbuis, rniwa, schenney, sergio, simon.fraser, thorton, webkit-bug-importer, zimmermann

Priority:

Keywords:

BrowserCompat, InRadar, WebExposed, WPTImpact

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=216984
https://bugs.webkit.org/show_bug.cgi?id=250575

Bug Depends on:

Bug Blocks:

191292, 200143

Attachments:

Description	Flags
Patch	none
Patch	none
Archive of layout-test-results from ews213 for win-future	none
Patch	sabouhallawa: review?

Said Abou-Hallawa

Reported 2019-11-12 12:58:20 PST

The link to the spec is: https://www.w3.org/TR/SVG/types.html#InterfaceSVGTests.

Attachments
Patch (209.53 KB, patch) 2019-11-12 13:43 PST, Said Abou-Hallawa	no flags	Details Formatted Diff Diff
Patch (221.77 KB, patch) 2019-11-12 16:23 PST, Said Abou-Hallawa	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews213 for win-future (14.78 MB, application/zip) 2019-11-12 19:09 PST, EWS Watchlist	no flags	Details
Patch (218.19 KB, patch) 2019-11-13 13:42 PST, Said Abou-Hallawa	sabouhallawa: review?	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Said Abou-Hallawa

Comment 1 2019-11-12 13:43:32 PST

Created attachment 383376 [details] Patch

Said Abou-Hallawa

Comment 2 2019-11-12 16:23:24 PST

Created attachment 383400 [details] Patch

EWS Watchlist

Comment 3 2019-11-12 16:24:41 PST

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

EWS Watchlist

Comment 4 2019-11-12 19:09:11 PST

Comment on attachment 383400 [details] Patch Attachment 383400 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/13244682 New failing tests: svg/W3C-SVG-1.1-SE/svgdom-over-01-f.svg

EWS Watchlist

Comment 5 2019-11-12 19:09:14 PST

Created attachment 383421 [details] Archive of layout-test-results from ews213 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews213 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

Said Abou-Hallawa

Comment 6 2019-11-13 13:42:49 PST

Created attachment 383490 [details] Patch

Frédéric Wang (:fredw)

Comment 7 2020-01-20 11:01:19 PST

@Said: Thanks for working on this! I think some Ryosuke and maybe others had concerns about this behavior change (see bug 198652 and https://lists.webkit.org/pipermail/webkit-dev/2019-June/030659.html ). Can you explain what's the status of the discussion here?

Ryosuke Niwa

Comment 8 2020-09-25 16:40:14 PDT

Comment on attachment 383490 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383490&action=review > Source/WebCore/ChangeLog:8 > + Remove these methods from SVGTests and fix the layout tests accordingly. How do we know this change is safe to make? We should probably put this under a runtime flag instead until we've successfully shipped it.

Frédéric Wang (:fredw)

Comment 9 2021-08-09 00:31:04 PDT

*** Bug 198652 has been marked as a duplicate of this bug. ***

Radar WebKit Bug Importer

Comment 10 2024-02-28 13:34:26 PST

<rdar://problem/123784300>

Tim Nguyen (:ntim)

Comment 11 2024-08-07 14:38:08 PDT

Bug 269827 has removed hasExtension.

Ahmad Saleem

Comment 12 2024-08-23 09:50:01 PDT

Pull request: https://github.com/WebKit/WebKit/pull/32630

EWS

Comment 13 2024-08-26 11:34:33 PDT

Committed 282754@main (4fb2feec1fbe): <https://commits.webkit.org/282754@main> Reviewed commits have been landed. Closing PR #32630 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.