| Summary: | [SVG2] Remove requiredFeatures and hasExtension from SVGTests | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Said Abou-Hallawa <sabouhallawa> | ||||||||||
| Component: | SVG | Assignee: | Said Abou-Hallawa <sabouhallawa> | ||||||||||
| Status: | NEW --- | ||||||||||||
| Severity: | Normal | CC: | ahmad.saleem792, berto, cdumez, cgarcia, dino, esprehn+autocc, ews-watchlist, fmalita, fred.wang, gustavo, gyuyoung.kim, heycam, kondapallykalyan, pdr, rbuis, rniwa, schenney, sergio, simon.fraser, thorton, webkit-bug-importer, zimmermann | ||||||||||
| Priority: | P2 | Keywords: | BrowserCompat, InRadar, WebExposed, WPTImpact | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=216984 https://bugs.webkit.org/show_bug.cgi?id=250575 |
||||||||||||
| Bug Depends on: | |||||||||||||
| Bug Blocks: | 191292, 200143 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Said Abou-Hallawa
2019-11-12 12:58:20 PST
Created attachment 383376 [details]
Patch
Created attachment 383400 [details]
Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Comment on attachment 383400 [details] Patch Attachment 383400 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/13244682 New failing tests: svg/W3C-SVG-1.1-SE/svgdom-over-01-f.svg Created attachment 383421 [details]
Archive of layout-test-results from ews213 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews213 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Created attachment 383490 [details]
Patch
@Said: Thanks for working on this! I think some Ryosuke and maybe others had concerns about this behavior change (see bug 198652 and https://lists.webkit.org/pipermail/webkit-dev/2019-June/030659.html ). Can you explain what's the status of the discussion here? Comment on attachment 383490 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383490&action=review > Source/WebCore/ChangeLog:8 > + Remove these methods from SVGTests and fix the layout tests accordingly. How do we know this change is safe to make? We should probably put this under a runtime flag instead until we've successfully shipped it. *** Bug 198652 has been marked as a duplicate of this bug. *** |