Bug 203959

Summary: [ews] rename RunJavaScriptCoreTestsToT to RunJSCTestsWithoutPatch
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, commit-queue, jbedard, pmatos, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=210190
Attachments:
Description Flags
Patch none

Aakash Jain
Reported 2019-11-07 09:09:17 PST
Rename RunJavaScriptCoreTestsToT to RunJSCTestsWithoutPatch since that's more accurate name. In EWS, when the jsc tests fails, we un-apply the patch and run tests on clean tree, not on ToT. We re-run the tests without patch on same revision on which tests were run with the patch. This naming would also make it consistent with other similar steps like: RunWebKitTestsWithout and RunAPITestsWithoutPatch.
Attachments
Patch (4.05 KB, patch)
2019-11-07 09:12 PST, Aakash Jain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2019-11-07 09:12:41 PST
Created attachment 383056 [details] Patch
Alexey Proskuryakov
Comment 2 2019-11-07 09:24:08 PST
Comment on attachment 383056 [details] Patch Why is webkitperl EWS red?
Aakash Jain
Comment 3 2019-11-07 09:54:45 PST
(In reply to Alexey Proskuryakov from comment #2) > Why is webkitperl EWS red? Not sure. It passed on retry. Filed: https://bugs.webkit.org/show_bug.cgi?id=203964
WebKit Commit Bot
Comment 4 2019-11-07 10:31:02 PST
Comment on attachment 383056 [details] Patch Clearing flags on attachment: 383056 Committed r252190: <https://trac.webkit.org/changeset/252190>
WebKit Commit Bot
Comment 5 2019-11-07 10:31:03 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-11-07 10:32:15 PST
<rdar://problem/56987785>
Note You need to log in before you can comment on or make changes to this bug.