Bug 203943 – Remove unimplemented property error log in when getting a property value from a computed style

• Component: CSS
• Status: RESOLVED FIXED

[Devin Rousso]

In r251581, the list of computed CSS properties was changed to be autogenerated from 'CSSProperties.json'.  One issue that arose from this was that `-webkit-text-decorations-in-effect` was no longer part of the `CSSComputedStyleDeclaration`, which caused a number of editing tests to fail, as that property is used for holding internal state related to various editing commands (e.g. `document.execCommand`).  In order to get around this, `ComputedStyleExtractor::copyProperties()` was modified to instead copy _all_ CSS properties, regardless of whether they're part of the set of computed CSS properties.  Unfortunately, this had a side effect of triggering a longstanding `LOG_ERROR` (added in r6178) when attempting to retrieve the value of certain CSS properties (e.g. `-internal-text-autosizing-status`).  Since this path can be triggered by any arbitrary JavaScript (e.g. `window.getComputedStyle(document.body).getPropertyCSSValue("-internal-text-autosizing-status")`), it doesn't add much benefit to have this log, especially since the code itself is already annotated with comments/FIXMEs for CSS properties that don't have a computed value.

[Devin Rousso]

Created attachment 383023 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 383023 [details]
Patch

Clearing flags on attachment: 383023

Committed r252176: <https://trac.webkit.org/changeset/252176>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/56973391>