Bug 203935

Summary: Web Inspector: Timelines: add a marker for when a stop was requested
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 196778    
Bug Blocks: 204827    
Attachments:
Description Flags
Patch
none
[Image] After Patch is applied none

Devin Rousso
Reported 2019-11-06 17:47:06 PST
After r244195, the Web Inspector frontend doesn't stop updating the current time marker until after it receives all of the corresponding `*.trackingComplete` events. This means that sometimes, the current time marker can move far past the time at which the stop was requested, such as if there's a blocking script (e.g. <https://wkwebviewtest.surge.sh>). We should indicate where the stop was requested, as that is often right after a particular issue is reproduced during a timeline recording (rather than have the user try to figure out (or worse, guess) where they stopped). It's still useful to have the current time marker continue updating, as we should show all the information we have about captured things, such as blocking scripts.
Attachments
Patch (7.92 KB, patch)
2019-11-06 17:50 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
[Image] After Patch is applied (187.71 KB, image/png)
2019-11-06 17:50 PST, Devin Rousso 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2019-11-06 17:50:35 PST
Created attachment 382993 [details] Patch
Devin Rousso
Comment 2 2019-11-06 17:50:49 PST
Created attachment 382994 [details] [Image] After Patch is applied
WebKit Commit Bot
Comment 3 2019-11-07 12:02:31 PST
Comment on attachment 382993 [details] Patch Clearing flags on attachment: 382993 Committed r252199: <https://trac.webkit.org/changeset/252199>
WebKit Commit Bot
Comment 4 2019-11-07 12:02:34 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2019-11-07 12:03:23 PST
<rdar://problem/56992319>
Note You need to log in before you can comment on or make changes to this bug.