Bug 203897

Summary:

Update libwebrtc to M78

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

WebRTC

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, alex, eric.carlson, pnormand, tsaunier, youennf

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

268258

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch with GTK/WPE fixes	none
Patch with GTK/WPE fixes	none
Patch	none
Patch	eric.carlson: review+

youenn fablet

Reported 2019-11-06 06:16:50 PST

Update libwebrtc to M78

Attachments
Patch (34.42 MB, patch) 2019-11-06 07:01 PST, youenn fablet	no flags	Details Formatted Diff Diff
Patch (34.43 MB, patch) 2019-11-06 11:41 PST, youenn fablet	no flags	Details Formatted Diff Diff
Patch (34.38 MB, patch) 2019-11-07 01:21 PST, youenn fablet	no flags	Details Formatted Diff Diff
Patch (33.89 MB, patch) 2019-11-07 15:44 PST, youenn fablet	no flags	Details Formatted Diff Diff
Patch (33.89 MB, patch) 2019-11-07 17:25 PST, youenn fablet	no flags	Details Formatted Diff Diff
Patch (33.89 MB, patch) 2019-11-07 22:35 PST, youenn fablet	no flags	Details Formatted Diff Diff
Patch (33.89 MB, patch) 2019-11-08 08:54 PST, youenn fablet	no flags	Details Formatted Diff Diff
Patch with GTK/WPE fixes (33.95 MB, patch) 2019-11-13 10:05 PST, youenn fablet	no flags	Details Formatted Diff Diff
Patch with GTK/WPE fixes (33.95 MB, patch) 2019-11-13 13:26 PST, youenn fablet	no flags	Details Formatted Diff Diff
Patch (33.95 MB, patch) 2019-11-13 16:05 PST, youenn fablet	no flags	Details Formatted Diff Diff
Patch (33.95 MB, patch) 2019-11-14 13:39 PST, youenn fablet	eric.carlson: review+	Details Formatted Diff Diff
Show Obsolete (10) View All Add attachment proposed patch, testcase, etc.

youenn fablet

Comment 1 2019-11-06 07:01:15 PST

Created attachment 382926 [details] Patch

youenn fablet

Comment 2 2019-11-06 11:41:54 PST

Created attachment 382944 [details] Patch

youenn fablet

Comment 3 2019-11-07 01:21:51 PST

Created attachment 383030 [details] Patch

youenn fablet

Comment 4 2019-11-07 15:44:09 PST

Created attachment 383085 [details] Patch

youenn fablet

Comment 5 2019-11-07 17:25:00 PST

Created attachment 383096 [details] Patch

youenn fablet

Comment 6 2019-11-07 22:35:50 PST

Created attachment 383112 [details] Patch

youenn fablet

Comment 7 2019-11-08 08:54:57 PST

Created attachment 383128 [details] Patch

Alex Christensen

Comment 8 2019-11-08 13:45:55 PST

You might find https://bugs.webkit.org/show_bug.cgi?id=203753 interesting. Maybe it could be put in with this, or just after? Could whoever gets the GTK build working with this patch look at that one, too?

youenn fablet

Comment 9 2019-11-08 14:56:12 PST

(In reply to Alex Christensen from comment #8) > You might find https://bugs.webkit.org/show_bug.cgi?id=203753 interesting. > Maybe it could be put in with this, or just after? Could whoever gets the > GTK build working with this patch look at that one, too? Interesting, I was actually thinking we could switch to Sources.txt/SourcesCocoa.txt mechanism. That would make it easier to update for all platforms. That would also help MacOS CMake.

youenn fablet

Comment 10 2019-11-13 10:05:28 PST

Created attachment 383464 [details] Patch with GTK/WPE fixes

Thibault Saunier

Comment 11 2019-11-13 10:24:23 PST

(In reply to Alex Christensen from comment #8) > You might find https://bugs.webkit.org/show_bug.cgi?id=203753 interesting. > Maybe it could be put in with this, or just after? Could whoever gets the > GTK build working with this patch look at that one, too? Sure, I will, I guess I will wait for that update patch to get in so you rebase and I have a look, is that OK for you?

youenn fablet

Comment 12 2019-11-13 10:48:58 PST

WPE bot does not seem to like it: StreamsConfig::StreamsConfig(const StreamsConfig&) = default; ^~~~~~~~~~~~~ In file included from ../../Source/ThirdParty/libwebrtc/Source/webrtc/api/transport/network_types.cc:11:0: ../../Source/ThirdParty/libwebrtc/Source/webrtc/api/transport/network_types.h:39:66: error: union member ‘webrtc::StreamsConfig::<unnamed union>::min_total_allocated_bitrate’ with non-trivial ‘constexpr std::optional<webrtc::DataRate>::optional(const std::optional<webrtc::DataRate>&)’ absl::optional<DataRate> min_total_allocated_bitrate = absl::nullopt; ^~~~~~~ ../../Source/ThirdParty/libwebrtc/Source/webrtc/api/transport/network_types.h:41:45: error: union member ‘webrtc::StreamsConfig::<unnamed union>::min_pacing_rate’ with non-trivial ‘constexpr std::optional<webrtc::DataRate>::optional(const std::optional<webrtc::DataRate>&)’ RTC_DEPRECATED absl::optional<DataRate> min_pacing_rate;

youenn fablet

Comment 13 2019-11-13 13:26:17 PST

Created attachment 383487 [details] Patch with GTK/WPE fixes

youenn fablet

Comment 14 2019-11-13 16:05:33 PST

Created attachment 383509 [details] Patch

youenn fablet

Comment 15 2019-11-14 13:39:13 PST

Created attachment 383572 [details] Patch

Eric Carlson

Comment 16 2019-11-14 14:22:33 PST

Comment on attachment 383572 [details] Patch r=me once the bots are happy.

youenn fablet

Comment 17 2019-11-14 17:03:32 PST

Committed revision 252472.

youenn fablet

Comment 18 2019-11-14 18:12:46 PST

Committed missing files in revision 252473.

Philippe Normand

Comment 19 2019-11-15 01:09:48 PST

https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Debug%20%28Build%29/builds/26235/steps/compile-webkit/logs/stdio

Philippe Normand

Comment 20 2019-11-15 01:10:59 PST

Ah, that was solved, there's a link error now https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Debug%20%28Build%29/builds/26241/steps/compile-webkit/logs/stdio

Note You need to log in before you can comment on or make changes to this bug.