Summary: | EWS should report test failures from clean-tree to results.webkit.org | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||
Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aakash_jain, ap, commit-queue, jbedard, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | Other | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
See Also: |
https://bugs.webkit.org/show_bug.cgi?id=202639 https://bugs.webkit.org/show_bug.cgi?id=204369 |
||||||
Attachments: |
|
Description
Aakash Jain
2019-11-04 15:16:07 PST
Created attachment 382791 [details]
Patch
Comment on attachment 382791 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382791&action=review > Tools/BuildSlaveSupport/ews-build/loadConfig.py:49 > + results_server_api_key = passwords.get('results-server-api-key') How do passwords for EWS work? Expected to see a json edit somewhere here.... We can talk about this offline. > Tools/BuildSlaveSupport/ews-build/steps.py:1466 > + def start(self): Don't think we set logEnviron to false for API tests (In reply to Jonathan Bedard from comment #2) > How do passwords for EWS work? It works similar to build.webkit.org > Don't think we set logEnviron to false for API tests It was already disabled in http://trac.webkit.org/changeset/246882/webkit (In reply to Aakash Jain from comment #3) > (In reply to Jonathan Bedard from comment #2) > > How do passwords for EWS work? > It works similar to build.webkit.org > Make sure that the master has access to the API key before deploying, otherwise every EWS run will fail > > Don't think we set logEnviron to false for API tests > It was already disabled in http://trac.webkit.org/changeset/246882/webkit Comment on attachment 382791 [details] Patch Clearing flags on attachment: 382791 Committed r252075: <https://trac.webkit.org/changeset/252075> All reviewed patches have been landed. Closing bug. We disabled the reporting (before it was deployed on server) in https://bugs.webkit.org/show_bug.cgi?id=204369 Re-opening for pull request https://github.com/WebKit/WebKit/pull/7362 Committed 257789@main (23a93ba0cddf): <https://commits.webkit.org/257789@main> Reviewed commits have been landed. Closing PR #7362 and removing active labels. |