Bug 203800

Summary: [LFC][MarginCollapsing] Add Line::isConsideredEmpty
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description zalan 2019-11-03 20:33:27 PST
https://www.w3.org/TR/CSS22/visuren.html#inline-formatting
Line boxes that contain no text, no preserved white space, no inline elements with non-zero margins, padding, or borders,
and no other in-flow content (such as images, inline blocks or inline tables), and do not end with a preserved newline
must be treated as zero-height line boxes for the purposes of determining the positions of any elements inside of them,
and must be treated as not existing for any other purpose.

Note that it does not necessarily mean visually non-empty line. <span style="font-size: 0px">this is still considered non-emptyine</span>
Comment 1 Radar WebKit Bug Importer 2019-11-03 20:33:37 PST
<rdar://problem/56854192>
Comment 2 zalan 2019-11-03 20:39:50 PST
Created attachment 382715 [details]
Patch
Comment 3 WebKit Commit Bot 2019-11-06 10:08:17 PST
The commit-queue encountered the following flaky tests while processing attachment 382715 [details]:

imported/w3c/web-platform-tests/websockets/bufferedAmount-unchanged-by-sync-xhr.any.worker.html bug 202003 (author: youennf@gmail.com)
webgl/1.0.3/conformance/extensions/webgl-draw-buffers.html bug 203878 (author: mmaxfield@apple.com)
The commit-queue is continuing to process your patch.
Comment 4 WebKit Commit Bot 2019-11-06 10:08:23 PST
The commit-queue encountered the following flaky tests while processing attachment 382715 [details]:

webgl/1.0.3/conformance/extensions/webgl-draw-buffers.html bug 203878 (author: mmaxfield@apple.com)
The commit-queue is continuing to process your patch.
Comment 5 WebKit Commit Bot 2019-11-06 13:02:08 PST
Comment on attachment 382715 [details]
Patch

Clearing flags on attachment: 382715

Committed r252143: <https://trac.webkit.org/changeset/252143>
Comment 6 WebKit Commit Bot 2019-11-06 13:02:10 PST
All reviewed patches have been landed.  Closing bug.