Bug 203744

Summary: Web Inspector: switching tabs should re-focus the previously focused element
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, eric.carlson, hi, inspector-bugzilla-changes, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 203743    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Devin Rousso
Reported 2019-11-01 09:57:42 PDT
# STEPS TO REPRODUCE: 1. inspect any page 2. select any item in the navigation sidebar of the Storage Tab 3. go to a different tab 4. go back to the Storage Tab => item selected in step #2 is no longer focused
Attachments
Patch (6.57 KB, patch)
2019-11-01 10:02 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2019-11-01 10:02:14 PDT
Created attachment 382591 [details] Patch
Blaze Burg
Comment 2 2019-11-01 12:04:52 PDT
Comment on attachment 382591 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382591&action=review r=me > Source/WebInspectorUI/UserInterface/Views/ContentBrowserTabContentView.js:317 > + if (treeElement) We still want selectedByUser = false, otherwise this will cause an extra history entry in the back/forward for the content area.
Devin Rousso
Comment 3 2019-11-01 13:52:38 PDT
Comment on attachment 382591 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382591&action=review >> Source/WebInspectorUI/UserInterface/Views/ContentBrowserTabContentView.js:317 >> + if (treeElement) > > We still want selectedByUser = false, otherwise this will cause an extra history entry in the back/forward for the content area. `selectedByUser` defaults to `false` if not provided (both due to the fact that `undefined` is falsy and that `WI.TreeOutline.prototype.selectTreeElementInternal` has an optional parameter) so the only change here should be to `omitFocus`.
WebKit Commit Bot
Comment 4 2019-11-01 18:27:21 PDT
Comment on attachment 382591 [details] Patch Clearing flags on attachment: 382591 Committed r251962: <https://trac.webkit.org/changeset/251962>
WebKit Commit Bot
Comment 5 2019-11-01 18:27:23 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-11-01 18:28:16 PDT
<rdar://problem/56834780>
Note You need to log in before you can comment on or make changes to this bug.