| Summary: | Python 3: Add support in webkitpy.layout_tests.model | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> | ||||||||||
| Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | aakash_jain, commit-queue, dewei_zhu, ews-watchlist, glenn, slewis, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=203701 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Jonathan Bedard
2019-10-31 16:18:34 PDT
Created attachment 382516 [details]
Patch
Comment on attachment 382516 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382516&action=review otherwise good > Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:-569 > - for test, modifiers in self._test_to_modifiers.iteritems(): can we make a compatibility function here as well. Created attachment 382530 [details]
Patch
Comment on attachment 382530 [details]
Patch
Either I'm blind or you forgot to include the iteration_compatibility file
Created attachment 382586 [details]
Patch
(In reply to Stephanie Lewis from comment #4) > Comment on attachment 382530 [details] > Patch > > Either I'm blind or you forgot to include the iteration_compatibility file Definitely forgot to include the iteration_compatibility.py file. Let's try this again... Created attachment 382658 [details]
Patch for landing
Comment on attachment 382658 [details] Patch for landing Clearing flags on attachment: 382658 Committed r251961: <https://trac.webkit.org/changeset/251961> All reviewed patches have been landed. Closing bug. |