Bug 203396

Summary: [Quick Look] Move the QLPreviewConverter delegate into PreviewConverter and vend a C++ client interface
Product: WebKit Reporter: Andy Estes <aestes>
Component: New BugsAssignee: Andy Estes <aestes>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, benjamin, cdumez, cmarcelo, commit-queue, dbates, ews-watchlist, japhet, koivisto, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Andy Estes
Reported 2019-10-24 20:51:39 PDT
[Quick Look] Move the QLPreviewConverter delegate into PreviewConverter and vend a C++ client interface
Attachments
Patch (61.15 KB, patch)
2019-10-24 21:08 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Patch (60.20 KB, patch)
2019-10-24 21:13 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Patch (59.99 KB, patch)
2019-10-24 22:26 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Andy Estes
Comment 1 2019-10-24 21:08:06 PDT Comment hidden (obsolete)
Andy Estes
Comment 2 2019-10-24 21:13:19 PDT Comment hidden (obsolete)
Andy Estes
Comment 3 2019-10-24 22:26:34 PDT
Created attachment 381880 [details] Patch
Alex Christensen
Comment 4 2019-10-25 10:32:39 PDT
Comment on attachment 381880 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381880&action=review > Source/WTF/wtf/FeatureDefines.h:222 > +#if PLATFORM(IOS) > +#define ENABLE_PREVIEW_CONVERTER 1 No IOS_FAMILY? This seems correct, but I'm double checking.
Andy Estes
Comment 5 2019-10-25 11:00:51 PDT
(In reply to Alex Christensen from comment #4) > Comment on attachment 381880 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=381880&action=review > > > Source/WTF/wtf/FeatureDefines.h:222 > > +#if PLATFORM(IOS) > > +#define ENABLE_PREVIEW_CONVERTER 1 > > No IOS_FAMILY? This seems correct, but I'm double checking. USE_QUICK_LOOK is also just IOS.
WebKit Commit Bot
Comment 6 2019-10-25 15:17:38 PDT
The commit-queue encountered the following flaky tests while processing attachment 381880 [details]: The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 7 2019-10-25 15:17:46 PDT
The commit-queue encountered the following flaky tests while processing attachment 381880 [details]: imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/integrity.html bug 203394 (author: ysuzuki@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 8 2019-10-25 18:48:12 PDT
Comment on attachment 381880 [details] Patch Clearing flags on attachment: 381880 Committed r251623: <https://trac.webkit.org/changeset/251623>
WebKit Commit Bot
Comment 9 2019-10-25 18:48:14 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2019-10-25 18:49:18 PDT
<rdar://problem/56639669>
Note You need to log in before you can comment on or make changes to this bug.