Bug 203388

Summary: [iOS] Regression(r251067) WebProcesses with service workers no longer keep their network process alive
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, commit-queue, ggaren, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2019-10-24 16:17:33 PDT
WebProcesses with service workers no longer keep their network process alive since r251067. This is causing hangs because the WebProcess gets stuck on sync IPC with the network process.
Attachments
Patch (2.78 KB, patch)
2019-10-24 16:31 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (2.78 KB, patch)
2019-10-24 17:01 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (2.81 KB, patch)
2019-10-24 21:45 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2019-10-24 16:31:02 PDT
Created attachment 381855 [details] Patch
Radar WebKit Bug Importer
Comment 2 2019-10-24 16:41:02 PDT
<rdar://problem/56600074>
Chris Dumez
Comment 3 2019-10-24 17:01:55 PDT
Created attachment 381860 [details] Patch
Geoffrey Garen
Comment 4 2019-10-24 21:28:03 PDT
Comment on attachment 381860 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381860&action=review r=me I'm surprised that our existing service worker tests don't exercise the case where you have a service worker and need to do a network load. I wonder if there's a way to test this. > Source/WebKit/ChangeLog:14 > + However, after r251067, there is no longer a concept of service worker process per say. Service workers per se
Chris Dumez
Comment 5 2019-10-24 21:45:47 PDT
Created attachment 381877 [details] Patch
WebKit Commit Bot
Comment 6 2019-10-24 23:45:40 PDT
The commit-queue encountered the following flaky tests while processing attachment 381877 [details]: The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 7 2019-10-24 23:45:48 PDT
The commit-queue encountered the following flaky tests while processing attachment 381877 [details]: imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/integrity.html bug 203394 (author: ysuzuki@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 8 2019-10-25 01:49:16 PDT
The commit-queue encountered the following flaky tests while processing attachment 381877 [details]: media/modern-media-controls/placard-support/placard-support-pip.html bug 195249 (author: graouts@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 9 2019-10-25 01:49:21 PDT
The commit-queue encountered the following flaky tests while processing attachment 381877 [details]: imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/integrity.html bug 203394 (author: ysuzuki@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 10 2019-10-25 02:49:59 PDT
The commit-queue encountered the following flaky tests while processing attachment 381877 [details]: fast/history/page-cache-webdatabase-pending-transaction.html bug 203399 (author: cdumez@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 11 2019-10-25 02:50:05 PDT
The commit-queue encountered the following flaky tests while processing attachment 381877 [details]: imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/integrity.html bug 203394 (author: ysuzuki@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 12 2019-10-25 03:47:19 PDT
The commit-queue encountered the following flaky tests while processing attachment 381877 [details]: fast/history/page-cache-webdatabase-pending-transaction.html bug 203399 (author: cdumez@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 13 2019-10-25 03:47:21 PDT
The commit-queue encountered the following flaky tests while processing attachment 381877 [details]: The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 14 2019-10-25 04:44:25 PDT
The commit-queue encountered the following flaky tests while processing attachment 381877 [details]: The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 15 2019-10-25 04:44:32 PDT
The commit-queue encountered the following flaky tests while processing attachment 381877 [details]: imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/integrity.html bug 203394 (author: ysuzuki@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 16 2019-10-25 06:01:12 PDT
Comment on attachment 381877 [details] Patch Clearing flags on attachment: 381877 Committed r251589: <https://trac.webkit.org/changeset/251589>
WebKit Commit Bot
Comment 17 2019-10-25 06:01:14 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.