Bug 203301

Summary: test262-runner should be able to pass JSC a feature flag
Product: WebKit Reporter: Ross Kirsling <ross.kirsling>
Component: Tools / TestsAssignee: Ross Kirsling <ross.kirsling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, keith_miller, leo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews211 for win-future
none
Patch for landing none

Ross Kirsling
Reported 2019-10-23 10:19:21 PDT
It's unfortunate that we currently need to disable things like BigInt and coalesce-expression in test262/config.yaml. Really what we'd like is have test262-runner know which flag should be passed to JSC in order to run such upcoming-feature tests.
Attachments
Patch (47.98 KB, patch)
2019-10-24 06:13 PDT, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews211 for win-future (13.85 MB, application/zip)
2019-10-24 13:25 PDT, EWS Watchlist 		no flags
Details
Patch for landing (47.86 KB, patch)
2019-10-25 01:24 PDT, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ross Kirsling
Comment 1 2019-10-24 06:13:11 PDT
Created attachment 381802 [details] Patch
Ross Kirsling
Comment 2 2019-10-24 06:15:05 PDT
Comment on attachment 381802 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381802&action=review > JSTests/test262/expectations.yaml:3422 > +test/language/statements/for-in/dstr/array-elem-nested-memberexpr-optchain-prop-ref.js: Note: All these for-in/for-of tests are for optional chaining, but they appear to be bogus. I've reported it here: https://github.com/tc39/test262/pull/2270#issuecomment-545880743
EWS Watchlist
Comment 3 2019-10-24 13:25:52 PDT Comment hidden (obsolete)
EWS Watchlist
Comment 4 2019-10-24 13:25:54 PDT Comment hidden (obsolete)
Keith Miller
Comment 5 2019-10-24 13:57:17 PDT
Comment on attachment 381802 [details] Patch r=me.
Keith Miller
Comment 6 2019-10-24 13:57:31 PDT
Thanks for doing this. Very helpful!
Ross Kirsling
Comment 7 2019-10-25 01:24:34 PDT
Created attachment 381895 [details] Patch for landing
WebKit Commit Bot
Comment 8 2019-10-25 03:09:42 PDT
The commit-queue encountered the following flaky tests while processing attachment 381895 [details]: imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/integrity.html bug 203394 (author: ysuzuki@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 9 2019-10-25 03:09:43 PDT
The commit-queue encountered the following flaky tests while processing attachment 381895 [details]: The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 10 2019-10-25 04:00:45 PDT
The commit-queue encountered the following flaky tests while processing attachment 381895 [details]: imported/w3c/web-platform-tests/content-security-policy/navigate-to/href-location-allowed.html bug 203405 (author: dbates@webkit.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 11 2019-10-25 04:00:51 PDT
The commit-queue encountered the following flaky tests while processing attachment 381895 [details]: imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/integrity.html bug 203394 (author: ysuzuki@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 12 2019-10-25 05:09:13 PDT
Comment on attachment 381895 [details] Patch for landing Clearing flags on attachment: 381895 Committed r251588: <https://trac.webkit.org/changeset/251588>
WebKit Commit Bot
Comment 13 2019-10-25 05:09:14 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 14 2019-10-25 05:10:16 PDT
<rdar://problem/56615193>
Note You need to log in before you can comment on or make changes to this bug.