Bug 203261

Summary: [ews] Status bubble should show previous failures if any in case patch is skipped
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=202163
Attachments:
Description Flags
Patch jbedard: review+

Aakash Jain
Reported 2019-10-22 11:49:33 PDT
[ews] Status bubble should show previous failures if any in case patch is skipped. For e.g.: if a patch failed EWS, and someone lands/obsoletes the patch, and then click on 'Retry failed builds' button, status-bubble for would be white (skipped). However the status-bubble doesn't indicate that before being skipped, patch did encountered failures. We should update the status-bubbble tool-tip for skipped patches so as to indicate the previous failures.
Attachments
Patch (1.69 KB, patch)
2019-10-22 11:52 PDT, Aakash Jain 		jbedard: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2019-10-22 11:52:40 PDT
Created attachment 381576 [details] Patch
Aakash Jain
Comment 2 2019-10-22 11:54:38 PDT
Sample run: Skipped build with previous failed build: https://ews.webkit-uat.org/status-bubble/381492/ (look at 'style' bubble) Skipped build without previous failed build: https://ews.webkit-uat.org/status-bubble/381322/
Aakash Jain
Comment 3 2019-10-22 13:48:11 PDT
Committed r251453: <https://trac.webkit.org/changeset/251453>
Radar WebKit Bug Importer
Comment 4 2019-10-22 13:49:15 PDT
<rdar://problem/56514010>
Note You need to log in before you can comment on or make changes to this bug.