Bug 202934

Summary: Web Inspector: REGRESSION(r250087): inspector/model/remote-object.html is timing out
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, ews-watchlist, hi, inspector-bugzilla-changes, joepeck, keith_miller, mark.lam, msaboff, saam, timothy, tzagallo, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 143589    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Yury Semikhatsky 2019-10-14 10:05:05 PDT 
Since https://trac.webkit.org/changeset/250087 injected script is not passing the test added for https://webkit.org/b/146141. It is timing out on the array with 1M entries because of changes in the following line:
 
processProperties(o, arrayIndexPropertyNames(o, Math.min(object.length, 100)), isOwnProperty); )
Comment 1 Yury Semikhatsky 2019-10-14 10:05:40 PDT 
Unfortunately the error was masked because the test is marked as flaky :(
Comment 2 Radar WebKit Bug Importer 2019-10-14 17:12:47 PDT 
<rdar://problem/56270900>
Comment 3 Devin Rousso 2019-11-05 17:17:18 PST 
Created attachment 382870 [details]
Patch
Comment 4 Devin Rousso 2019-11-05 19:26:47 PST 
Created attachment 382884 [details]
Patch

Fix WK1 test expectations
Comment 5 Devin Rousso 2019-11-05 19:28:06 PST 
Created attachment 382885 [details]
Patch

Fix WK1 test expectations (this time actually uploading the file)
Comment 6 WebKit Commit Bot 2019-11-07 12:37:06 PST 
Comment on attachment 382885 [details]
Patch

Clearing flags on attachment: 382885

Committed r252202: <https://trac.webkit.org/changeset/252202>
Comment 7 WebKit Commit Bot 2019-11-07 12:37:07 PST 
All reviewed patches have been landed.  Closing bug.