Bug 202639

Summary: results.webkit.org: Start reporting results
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, dean_johnson, dewei_zhu, ews-watchlist, glenn, jlewis3, lingho, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=202928
https://bugs.webkit.org/show_bug.cgi?id=203829
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch dewei_zhu: review+

Description Jonathan Bedard 2019-10-07 09:13:08 PDT 
We should start reporting test results to the new results.webkit.org.

To do this, we have to pass an API key through from the master to each test run which uploads results.
Comment 1 Jonathan Bedard 2019-10-07 09:58:24 PDT 
Created attachment 380335 [details]
Patch
Comment 2 dewei_zhu 2019-10-07 12:04:29 PDT 
Comment on attachment 380335 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380335&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/loadConfig.py:52
> +    results_server_api_key = passwords.get('RESULTS_SERVER_API_KEY')

We usually use lower case for config json keys?
Comment 3 Jonathan Bedard 2019-10-07 13:07:35 PDT 
Committed r250784: <https://trac.webkit.org/changeset/250784>
Comment 4 Radar WebKit Bug Importer 2019-10-07 13:08:18 PDT 
<rdar://problem/56047710>
Comment 5 Matt Lewis 2019-10-08 12:38:49 PDT 
Reverted r250784 for reason:

Broke running layout tests.

Committed r250851: <https://trac.webkit.org/changeset/250851>
Comment 6 Jonathan Bedard 2019-10-08 12:42:20 PDT 
(In reply to Matt Lewis from comment #5)
> Reverted r250784 for reason:
> 
> Broke running layout tests.
> 
> Committed r250851: <https://trac.webkit.org/changeset/250851>

This was at my request. Don't want to be rushed when root-causing this failure.
Comment 7 Jonathan Bedard 2019-10-08 17:25:33 PDT 
Created attachment 380483 [details]
Patch
Comment 8 Jonathan Bedard 2019-10-09 09:03:43 PDT 
Created attachment 380536 [details]
Patch
Comment 9 Jonathan Bedard 2019-10-09 13:33:37 PDT 
Created attachment 380561 [details]
Patch
Comment 10 dewei_zhu 2019-10-09 14:09:24 PDT 
Comment on attachment 380561 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380561&action=review

> Tools/Scripts/webkitpy/results/upload_unittest.py:129
> +        with mock.patch('requests.post', new=lambda url, headers={}, data={}: self.MockResponse()):

Is this syntax valid? `data={}: self.MockResponse()`?
Comment 11 dewei_zhu 2019-10-09 14:10:55 PDT 
Comment on attachment 380561 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380561&action=review

>> Tools/Scripts/webkitpy/results/upload_unittest.py:129
>> +        with mock.patch('requests.post', new=lambda url, headers={}, data={}: self.MockResponse()):
> 
> Is this syntax valid? `data={}: self.MockResponse()`?

Never mind. Missed `lambda`
Comment 12 Jonathan Bedard 2019-10-10 07:47:15 PDT 
Committed r250966: <https://trac.webkit.org/changeset/250966>