Bug 202627

Summary: [iOS] Unmuting capture of a page is not working
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, dbates, eric.carlson, esprehn+autocc, ews-watchlist, glenn, hta, jer.noble, kangil.han, philipj, sergio, tommyw, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 202630    
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Description youenn fablet 2019-10-07 02:59:28 PDT 
[iOS] Unmuting capture of a page is not working
Comment 1 youenn fablet 2019-10-07 03:09:35 PDT 
Created attachment 380311 [details]
Patch
Comment 2 youenn fablet 2019-10-07 03:20:15 PDT 
<rdar://problem/55970691>
Comment 3 youenn fablet 2019-10-07 05:50:43 PDT 
Created attachment 380317 [details]
Patch
Comment 4 Eric Carlson 2019-10-07 06:07:47 PDT 
Comment on attachment 380317 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380317&action=review

> Source/WebCore/ChangeLog:8
> +        Before the patch, we were muting the captur tracks but never unmuting them.

s/captur/capture/

> Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp:479
> +void MediaStreamTrack::updateCaptureAccordingMutedState(Document& document)

Nit: updateCaptureAccordingToMutedState would be slightly clearer.
Comment 5 youenn fablet 2019-10-07 06:49:10 PDT 
Created attachment 380322 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2019-10-07 07:36:24 PDT 
Comment on attachment 380322 [details]
Patch for landing

Clearing flags on attachment: 380322

Committed r250774: <https://trac.webkit.org/changeset/250774>
Comment 7 WebKit Commit Bot 2019-10-07 07:36:26 PDT 
All reviewed patches have been landed.  Closing bug.