Bug 202497

Summary: Resync WPT shadow DOM tests
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Tools / TestsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, koivisto, sam, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 166484    
Attachments:
Description Flags
Resynced tests
none
Patch for landing none

Description Ryosuke Niwa 2019-10-02 15:30:47 PDT
Update the tests.
Comment 1 Ryosuke Niwa 2019-10-02 15:33:32 PDT
Created attachment 380067 [details]
Resynced tests
Comment 2 Ryosuke Niwa 2019-10-02 15:35:51 PDT
Note: this patch takes https://github.com/web-platform-tests/wpt/pull/19479 into account.
Comment 3 Sam Weinig 2019-10-02 15:37:19 PDT
Comment on attachment 380067 [details]
Resynced tests

rs=me
Comment 4 Ryosuke Niwa 2019-10-02 15:39:42 PDT
Thanks!
Comment 5 Ryosuke Niwa 2019-10-02 21:28:36 PDT
Created attachment 380079 [details]
Patch for landing
Comment 6 Ryosuke Niwa 2019-10-02 21:29:29 PDT
Comment on attachment 380079 [details]
Patch for landing

Wait for EWS.
Comment 7 Ryosuke Niwa 2019-10-02 21:30:29 PDT
Apparently sending tab key via UIController doesn't move the focus forward on iOS. There are tests with form controls where it seems to be working so it's rather mysterious. It probably needs to be investigated in another bug as there are other tests that are currently skipped on iOS for similar reasons.
Comment 8 Ryosuke Niwa 2019-10-03 16:53:44 PDT
Hm... I can't reproduce the test failure of imported/w3c/web-platform-tests/mathml/relations/html5-tree/tabindex-002.html on macOS Mojave. Maybe it's high Sierra only?? That's weird though...
Comment 9 Ryosuke Niwa 2019-10-03 16:56:07 PDT
This is so frustrating. I've been trying to land this patch for the last three days :(
Comment 10 Ryosuke Niwa 2019-10-03 19:00:15 PDT
Committed r250696: <https://trac.webkit.org/changeset/250696>
Comment 11 Radar WebKit Bug Importer 2019-10-03 19:01:17 PDT
<rdar://problem/55970683>