Bug 20243

Summary: Potential crash with RenderLayer clipRects
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Layout and RenderingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: dino
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
Patch hyatt: review+

Description Simon Fraser (smfr) 2008-07-31 11:14:03 PDT
Bug 20066 changed RenderLayer::calculateClipRects() to not call parent()->calculateClipRects() in some situations. That means that the parent's clipRects are no longer guaranteed to be set up, so the code lower in the method needs to protect against this.
Comment 1 Simon Fraser (smfr) 2008-07-31 11:20:25 PDT
I haven't been able to actually crash, but here's a null-check patch.
Comment 2 Simon Fraser (smfr) 2008-07-31 11:22:20 PDT
Created attachment 22580 [details]
Patch
Comment 3 Dave Hyatt 2008-07-31 13:09:30 PDT
Comment on attachment 22580 [details]
Patch

r=me
Comment 4 Simon Fraser (smfr) 2008-07-31 14:11:18 PDT
Committed r35496
	M	WebCore/rendering/RenderLayer.cpp
	M	WebCore/ChangeLog
r35496 = aec6a3acb56598eac0ab03de1d44cb8679883d72 (trunk)