| Summary: | [JSC] SamplingProfiler should recognize RegExp execution | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||||
| Component: | JavaScriptCore | Assignee: | Yusuke Suzuki <ysuzuki> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | annulen, ews-watchlist, gyuyoung.kim, joepeck, keith_miller, mark.lam, msaboff, ryuan.choi, sbarati, sergio, tzagallo, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Yusuke Suzuki
2019-09-11 15:41:37 PDT
After looking into the current SamplingProfiler and RegExp code, I think maybe, we should take a very simple way that is previously done in the previous patch because, 1. Yarr RegExp JIT code is not following JS calling-convention right now. And if we want to do that, we need to execute Yarr RegExp through LLInt vmEntry, it is not desirable. 2. RegExp JIT code must be a leaf of execution in terms of SamplingProfiler. So, just recording in VM is enough. Created attachment 378721 [details]
Patch
Created attachment 433646 [details]
Patch
Comment on attachment 433646 [details]
Patch
Nice. r=me
Committed r279976 (239719@main): <https://commits.webkit.org/239719@main> *** Bug 190336 has been marked as a duplicate of this bug. *** Whoa! Awesome |