Bug 201702

Summary: [JSC] SamplingProfiler should recognize RegExp execution
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: JavaScriptCoreAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, ews-watchlist, gyuyoung.kim, joepeck, keith_miller, mark.lam, msaboff, ryuan.choi, saam, sergio, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch saam: review+

Yusuke Suzuki
Reported 2019-09-11 15:41:37 PDT
Simply to investigate what RegExp is taking long time in several JetStream2 benchmarks.
Attachments
Patch (58.46 KB, patch)
2019-09-13 03:45 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (49.01 KB, patch)
2021-07-15 18:51 PDT, Yusuke Suzuki 		saam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-09-11 15:42:14 PDT
<rdar://problem/55279830>
Yusuke Suzuki
Comment 2 2019-09-13 02:43:57 PDT
After looking into the current SamplingProfiler and RegExp code, I think maybe, we should take a very simple way that is previously done in the previous patch because, 1. Yarr RegExp JIT code is not following JS calling-convention right now. And if we want to do that, we need to execute Yarr RegExp through LLInt vmEntry, it is not desirable. 2. RegExp JIT code must be a leaf of execution in terms of SamplingProfiler. So, just recording in VM is enough.
Yusuke Suzuki
Comment 3 2019-09-13 03:45:55 PDT
Created attachment 378721 [details] Patch
Yusuke Suzuki
Comment 4 2021-07-15 18:51:27 PDT
Created attachment 433646 [details] Patch
Saam Barati
Comment 5 2021-07-15 20:01:41 PDT
Comment on attachment 433646 [details] Patch Nice. r=me
Yusuke Suzuki
Comment 6 2021-07-15 21:10:59 PDT
Committed r279976 (239719@main): <https://commits.webkit.org/239719@main>
Yusuke Suzuki
Comment 7 2021-07-16 18:20:42 PDT
*** Bug 190336 has been marked as a duplicate of this bug. ***
Joseph Pecoraro
Comment 8 2021-07-19 10:29:13 PDT
Whoa! Awesome
Note You need to log in before you can comment on or make changes to this bug.